-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor typedefs for cy #3499
Merged
Merged
refactor typedefs for cy #3499
Changes from 11 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
08b8392
refactor typedefs for cy
kuceb b9671c1
Merge remote-tracking branch 'origin/develop' into HEAD
kuceb 95e7c11
fix dtslint
kuceb 6e5f65b
fix dtslint
kuceb feca8af
Merge branch 'develop' into typings-fix
kuceb 37f9b89
Merge branch 'develop' into typings-fix
kuceb 432c040
Merge branch 'develop' into typings-fix
bahmutov bed50de
add test for extending types
kuceb a6813c1
Merge branch 'develop' into typings-fix
kuceb 30377f7
typo
kuceb f9a546e
Merge branch 'develop' into typings-fix
bahmutov 76ed91b
docs and examples for cy type
bahmutov d9fc486
Merge branch 'develop' into typings-fix
bahmutov 2f84363
sorted props
bahmutov f3ceda2
remove a few tabs
bahmutov 43eb773
better jsdoc
bahmutov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/** | ||
* Test that plugin authors can write .d.ts files to extend Cypress types | ||
* Unfortunately we cannot test that vendor types located in node_modules are working | ||
* since those are copied as part of the deploy process | ||
* | ||
*/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this needs more documentation - this is what someone who writes a new command or adds a property to Also, the formatting is all off below, maybe it needs a prettier ... |
||
|
||
declare namespace Cypress { | ||
interface cy { | ||
cyProp: number | ||
} | ||
interface Chainable { | ||
chainerProp: number | ||
} | ||
} | ||
|
||
// $ExpectType number | ||
cy.cyProp | ||
|
||
// $ExpectError | ||
cy.get('.element').cyProp | ||
|
||
// $ExpectType number | ||
cy.chainerProp | ||
|
||
// $ExpectType number | ||
cy.get('.element').chainerProp |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this interface
cy
be documented please?