Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JMAP contacts support to IETF standards #4479

Merged
merged 169 commits into from
Oct 9, 2023
Merged

Update JMAP contacts support to IETF standards #4479

merged 169 commits into from
Oct 9, 2023

Conversation

ksmurchison
Copy link
Contributor

@ksmurchison ksmurchison requested a review from rsto April 13, 2023 16:48
@ksmurchison ksmurchison marked this pull request as draft April 13, 2023 16:48
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 5 times, most recently from e0990d5 to 112ef46 Compare April 27, 2023 15:00
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 4 times, most recently from a039f78 to 838cfae Compare May 2, 2023 16:50
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 3 times, most recently from 79af45a to 4084d70 Compare May 10, 2023 17:17
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 3 times, most recently from cade6dd to c2d8066 Compare May 18, 2023 11:38
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 2 times, most recently from e546e06 to 8a35ca7 Compare May 28, 2023 13:06
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 2 times, most recently from a00fbf6 to ecb0bf1 Compare June 9, 2023 11:45
@ksmurchison ksmurchison marked this pull request as ready for review June 12, 2023 18:40
@ksmurchison ksmurchison changed the title WIP: Update JMAP contacts support to IETF standards Update JMAP contacts support to IETF standards Jun 12, 2023
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 3 times, most recently from 89d49a9 to e301bd7 Compare July 26, 2023 15:11
ksmurchison and others added 24 commits October 5, 2023 07:17
@ksmurchison
jmap_contact.c: order name/address comps per vCard structrured fields
30ef6f6
@rsto @ksmurchison
jmap_contact: add disableUriAsBlobId argument to Card{get/parse}
d65d810 
Signed-off-by: Robert Stepanek <rsto@fastmailteam.com>
@rsto @ksmurchison
jmap_contact: reject reserved 'extra' property
344cdec 
Signed-off-by: Robert Stepanek <rsto@fastmailteam.com>
@ksmurchison
jmap_contact.c: reorganize N/ADR field to name/address comp maps
82f6d78
@ksmurchison
jmap_contatc.c: handle ordered N/ADR with PHONETICs
f20b65c
@ksmurchison
jmap_contact.c: cleanup _to_jmap_date()
fe3e424
@ksmurchison
jmap_contact.c: only allow LABEL parameter on ADR property
65fef13
@ksmurchison
jmap_contact.c: fix handling of vCardProps and vCardParams
4f50f05
@ksmurchison
jmap_contact.c: better X-ABLabel handling
5738d79
@ksmurchison
jmap_contact.c: reorganize jmap_card_from_vcard()
f637625
@ksmurchison
jmap_contact.c: don't parse/dump vCard data from message if fetching …
17ec702 
…full card
@ksmurchison
jmap_contact.c: #ifdef protect Address/* methods
5e17e78
@ksmurchison
configure.ac, cyr_buildinfo.c: flag libicalvcard dependency
88c19d2
@ksmurchison
All AddressBook and ContactCard tests depend on libicalvcard
5887ddb
@ksmurchison
index.c: use new charset_to_utf8() api
eb3cb70
@ksmurchison
JMAPContacts: with/without libicalvcard fixes
b9dcfe5
@ksmurchison
JMAPContacts.pm: properly gate contacts using URN
6d81cbc
@ksmurchison
jmap_util.c: fix jmap_patchobject_apply()
fea9cfc
@rsto @ksmurchison
jmap_util.c: ignore non-existent patch target for null values
262df70 
Signed-off-by: Robert Stepanek <rsto@fastmailteam.com>
@rsto @ksmurchison
http_carddav: free charset after use
1bb7c38 
Signed-off-by: Robert Stepanek <rsto@fastmailteam.com>
@ksmurchison
jmap_contact.c: plug memory leaks on Contact/set{update} failures
ea7fed4
@ksmurchison
carddav_db.c: DAV sync-collection passes kind as -1
8d31ff8
@ksmurchison
Carddav.pm: added test_sync_collection
9af179b
@ksmurchison
jmap_contact.c: use object cache for ContactCards
6922fbc
@ksmurchison ksmurchison merged commit d94f5a3 into master Oct 9, 2023
0 of 2 checks passed
@elliefm
Copy link
Contributor

elliefm commented Oct 10, 2023

This was merged with failing CI checks 👎

@ksmurchison
Copy link
Contributor Author

What's failing?