Processimip rrule complete #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksmurchison
approved these changes
Jun 28, 2023
ksmurchison
force-pushed
the
processimip-rrule-complete
branch
from
27722dc
to
c2fe7fb
Compare
|
@brong As requested, I updated this to NOT run past the end of the recurrence set |
brong
force-pushed
the
processimip-rrule-complete
branch
from
c2fe7fb
to
60dd9fe
Compare
|
hah oops, I made basically the same changes and force pushed them on top too, since I still had it checked out. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ken, as promised, here's the test case and also a really basic possible solution to it, just to double check my logic.