mailbox_get_xconvemodseq() is never called with NULL for *modseqp #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way the function was written implied that the parameter modseqp could be NULL. If it were NULL, then “*modseqp = status.threadmodseq;” would cause NULL-dereference. In practice the function is never called with NULL as last parameter.
dilyanpalauzov
force-pushed
the
mailbox_get_xconvemodseq_modseq_nonnull
branch
from
9260f0a
to
1755d89
Compare
brong
requested changes
Sep 25, 2023
| @@ -4387,9 +4387,6 @@ EXPORTED int mailbox_get_xconvmodseq(struct mailbox *mailbox, modseq_t *modseqp) | |||
| conv_status_t status = CONV_STATUS_INIT; | |||
| int r; | |||
|
|
|||
| if (modseqp) | |||
There was a problem hiding this comment.
We should just remove the test here, or put an assert(modseqp)
There was a problem hiding this comment.
This changeset removes the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the function was written implied that the parameter modseqp could be NULL. If it were NULL, then “*modseqp = status.threadmodseq;” would cause NULL-dereference.
In practice the function is never called with NULL as last parameter.
This silences a warning from the Clang Static Analyzer.