Makefile.am: install lib/xsha1.h #4623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/charset.h is installed and it #includes xsha1.h xsha1.h includes "lib/assert.h", so assert.h has to be installed under include/cyrus/lib/assert.h .
elliefm
added a commit
to elliefm/cyrus-imapd
that referenced
this pull request
Jan 23, 2024
Needed by charset.h, which is installed. Based on cyrusimap#4623, originally by @dilyanpalauzov
|
Thanks, and sorry to have not addressed this earlier. I'm tackling this a bit differently in #4798 by also removing the "lib/" from some of the include lines so that the "nobase_include_HEADERS" section isn't required. This came up cause the Debian package maintainer privately reported a problem from the abi-compatibility-checker not being able to run due to the headers not compiling. I'm expecting further similar things to turn up from getting that working, so I'll accumulate those in my draft PR and land the lot once the checker can actually run. |
elliefm
added a commit
to elliefm/cyrus-imapd
that referenced
this pull request
Jan 31, 2024
Needed by charset.h, which is installed. Based on cyrusimap#4623, originally by @dilyanpalauzov
elliefm
added a commit
to elliefm/cyrus-imapd
that referenced
this pull request
Feb 21, 2024
Needed by charset.h, which is installed. Based on cyrusimap#4623, originally by @dilyanpalauzov
elliefm
added a commit
to elliefm/cyrus-imapd
that referenced
this pull request
Apr 26, 2024
Needed by charset.h, which is installed. Based on cyrusimap#4623, originally by @dilyanpalauzov
elliefm
added a commit
to elliefm/cyrus-imapd
that referenced
this pull request
Aug 14, 2024
Needed by charset.h, which is installed. Based on cyrusimap#4623, originally by @dilyanpalauzov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/charset.h is installed and it #includes xsha1.h
xsha1.h includes "lib/assert.h", so assert.h has to be installed under include/cyrus/lib/assert.h .