Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync_support: stronger logging in sync_mailbox_compare_update #4751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sync_support: stronger logging in sync_mailbox_compare_update #4751

wants to merge 1 commit into from

Conversation

elliefm
Copy link
Contributor

@elliefm elliefm commented Nov 29, 2023

We might abort if this returns non-zero, so let's make sure to loudly log why we're returning non-zero...

brong
brong approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@brong brong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look good - though some of these are legit "there was a split brain", and maybe should change to LOG_NOTICE and be SYNC_NOTICE still.

@brong brong self-requested a review November 29, 2023 03:27
@rsto rsto removed their request for review August 20, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksmurchison ksmurchison Awaiting requested review from ksmurchison

@brong brong Awaiting requested review from brong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliefm @brong