-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
caldav_alarm.c: switch from using mboxname to mboxid + inboxid #4842
base: mboxlist_inboxid
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a memory leak...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't the upgrade code have race conditions with a concurrent user rename? Or maybe I just don't see how the code prevents that.
45b1890
to
ea83841
Compare
c66e215
to
7de63e3
Compare
ea83841
to
19c4d9c
Compare
7de63e3
to
75d6641
Compare
@brong Regarding @rsto's question about a race. The upgrade code runs the first time caldav_alarm_open() is called. |
We'd probably need to do both anyway, because wait daemon mode doesn't guarantee the daemon is only run during startup, only that when it is run during startup, it runs before services and other daemons start. If the daemon crashes or otherwise exits once services are already running, master will just restart it like a normal daemon. (Though presumably at that point the upgrade has already run, so there's no problem... as long as the upgrade isn't the cause of the crash/exit.) We'd need to instruct people to add wait=y to their calalarmd entry, and some won't read or follow that instruction, and potentially trip over something later.
Same potential issue wrt people upgrading without reading instructions. Can we make |
Yes. We can probably just have it call caldav_alarm_upgrade(). @brong What do you think? |
19c4d9c
to
ecc9746
Compare
ecc9746
to
5ea6581
Compare
@ksmurchison I'm going to unassign my review status from this PR. Please add me for review again when this PR is ready for re-review. |
5ea6581
to
23f7955
Compare
Requires mboxlist_inboxid