JMAP Contacts: preserve x-properties in Contact/copy #4987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsto
force-pushed
the
jmap_copy_preserve_xprops
branch
from
cd5bba9
to
b0694cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
Contact/copymethod of the non-standard Contact object type to preserve arbitrary x-properties in the copied vCard.It adds the
vCardPropsproperty as defined in https://www.rfc-editor.org/rfc/rfc9555.html#name-vcardprops to the Contact object type The implementation is for Cyrus-internal use only andContact/setandContact/getreject this property as unknown.Also contained in this PR is a related, minor fix:
Contact/setnow replaces rather than adds the non-standard phonetic contact properties.