Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message.c: fix reading cached bodystructure for "message/global" #4988

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

rsto
Copy link
Member

@rsto rsto commented Jul 30, 2024

Fixes a bug in which cached bodystructures having a cache version less than the current version 13 failed to parse.

Fixes a bug in which cached bodystructures having a cache version
less than the current version 13 failed to parse.
@rsto
Copy link
Member Author

rsto commented Jul 30, 2024

Testing this in Cassandane is not feasible since this only impacts parsing cache files older than the Cyrus version being tested. Likewise, mangling the cache file in a Cassandane test file is likely to produce bogus results in the future.
I tested this manually.

Copy link
Contributor

@ksmurchison ksmurchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works in testing LGTM

@rsto rsto merged commit 66279e3 into cyrusimap:master Sep 2, 2024
1 check passed
@rsto rsto deleted the message_parse_cache_version_lt_13 branch September 2, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants