Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml_add_ns: try a different namespace prefix, if the current one is in use #5003

Merged

Conversation

dilyanpalauzov
Copy link
Contributor

The problem is with XML requests, which utilize in a child node a namespace with a prefix, which prefix was already added in the XML response to the root node.

Closes: #4489

Copy link
Contributor

@ksmurchison ksmurchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extend the Caldav:calendar_setcolor test to include the set of problematic PROPFINDs? And then I will approve and merge. Thank you

…n use

The problem is with XML requests, which utilize in a child node a
namespace with a prefix, which prefix was already added in the XML
response to the root node.
@dilyanpalauzov
Copy link
Contributor Author

I have taken the modified test from #5007.

The very right correction would be to wrap all calls of xmlNewNs() in a function, which retries calling xmlNewNs() with different prefixes, until xmlNewNs() returns non-NULL.

@ksmurchison ksmurchison merged commit ee5db7b into cyrusimap:master Aug 25, 2024
1 check passed
@dilyanpalauzov dilyanpalauzov deleted the xml_namespace_prefix_collision branch August 25, 2024 17:31
@dilyanpalauzov
Copy link
Contributor Author

This should be backported.

@elliefm elliefm added backport-to-3.6 for PRs that are to be backported to 3.6 backport-to-3.4 for PRs that are to be backported to 3.4 backport-to-3.2 for PRs that are to be backported to 3.2 backport-to-3.8 for PRs that are to be backported to 3.8 backport-to-3.10 for PRs that are to be backported to 3.10 labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-3.2 for PRs that are to be backported to 3.2 backport-to-3.4 for PRs that are to be backported to 3.4 backport-to-3.6 for PRs that are to be backported to 3.6 backport-to-3.8 for PRs that are to be backported to 3.8 backport-to-3.10 for PRs that are to be backported to 3.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calendar-color "changes" namespace
3 participants