Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cass smtpd refactor #5005

Merged
merged 9 commits into from
Sep 3, 2024
Merged

cass smtpd refactor #5005

merged 9 commits into from
Sep 3, 2024

Commits on Aug 26, 2024

  1. utils/fakesmtpd: split out from Instance

    @elliefm
    elliefm committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8336524 View commit details
    Browse the repository at this point in the history

  2. various: cass smtp tests no longer hang in verbose mode 

    so we don't need to conditionally skip them anymore
    @elliefm
    elliefm committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    faa9f8f View commit details
    Browse the repository at this point in the history

  3. Net::SMTPServer: switch from PreForkSimple to PreFork 

    spawns fewer fakesmtpd processes when they're not being used
    @elliefm
    elliefm committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c22d333 View commit details
    Browse the repository at this point in the history

  4. Net::SMTPServer: initialise and reset _rcpt_to_count 

    * Reset it to zero on MAIL FROM and RSET, because these server
  processes can be reused for multiple emails or connections.  This
  effectively makes it a per-message recipient limit, where
  previously it was a per-process limit
* Explicitly initialise it to zero in new, so that it's obvious it
  exists
    @elliefm
    elliefm committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    75d16a7 View commit details
    Browse the repository at this point in the history

  5. TestCase: replica config from base config, not instance config

    @elliefm
    elliefm committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9b4eeba View commit details
    Browse the repository at this point in the history

  6. MaxMessages: fix warnings from misholding make_message

    @elliefm
    elliefm committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    800091d View commit details
    Browse the repository at this point in the history

  7. Config: make smtp configuration invalid by default 

    Cyrus will default to sending outgoing mail via sendmail if not
otherwise configured, which is potentially a problem when running
Cassandane on a machine configured to send mail to the world.

Make Cassandane set Cyrus up with an invalid smtp configuration by
default, so that if some test case hits smtpclient_open without
having been set up for it, the test just breaks instead of sending
mail.
    @elliefm
    elliefm committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1a97e52 View commit details
    Browse the repository at this point in the history

  8. TestCase: only start fakesmtpd for tests that need it

    @elliefm
    elliefm committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f504578 View commit details
    Browse the repository at this point in the history

  9. various: request smtpdaemon for tests that need it

    @elliefm
    elliefm committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    3b601fd View commit details
    Browse the repository at this point in the history