Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestPlan: check for bad/orphaned tiny-tests #5011

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

elliefm
Copy link
Contributor

@elliefm elliefm commented Aug 28, 2024

Makes Cassandane check for various bad tiny-tests conditions at startup. This is mostly useful for detecting mistakes while backporting changes to older versions that don't have tiny tests at all, or don't use them as much as as master does. It might also be helpful when implementing new tiny-tests suites if you're not just converting an existing suite using the tool.

It complains about:
* test suites that try to Cassandane::Tiny::Loader a nonexistent directory
* multiple test suites that Cassandane::Tiny::Loader the same directory
* tiny-tests directories that no test suite calls Cassandane::Tiny::Loader on
* tiny-tests directories that don't contain any tests

It's implemented as a sanity check within Cassandane::Unit::TestPlan, not within Cassandane::Tiny, because its main purpose is to be run on the release branches where Cassandane::Tiny doesn't necessarily exist, in order to detect accidentally created tiny-tests files that will never get executed

@elliefm elliefm force-pushed the v311/cass-orphaned-tiny-tests branch 3 times, most recently from 94fa8ae to 1291462 Compare August 30, 2024 01:25
@elliefm elliefm added backport-to-3.6 for PRs that are to be backported to 3.6 backport-to-3.4 for PRs that are to be backported to 3.4 backport-to-3.2 for PRs that are to be backported to 3.2 backport-to-3.8 for PRs that are to be backported to 3.8 backport-to-3.10 for PRs that are to be backported to 3.10 labels Aug 30, 2024
@elliefm elliefm marked this pull request as ready for review August 30, 2024 03:02
Copy link
Member

@rsto rsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not run into the issues this PR aims to resolve but I'm not much doing backporting work.
Code looks good to me. If it works, it works.

@elliefm elliefm force-pushed the v311/cass-orphaned-tiny-tests branch from 1291462 to b322469 Compare September 3, 2024 23:56
@elliefm elliefm merged commit 32817b6 into cyrusimap:master Sep 4, 2024
1 check passed
@elliefm elliefm deleted the v311/cass-orphaned-tiny-tests branch September 4, 2024 00:18
@elliefm elliefm removed backport-to-3.10 for PRs that are to be backported to 3.10 backport-to-3.8 for PRs that are to be backported to 3.8 backport-to-3.6 for PRs that are to be backported to 3.6 backport-to-3.4 for PRs that are to be backported to 3.4 backport-to-3.2 for PRs that are to be backported to 3.2 labels Sep 4, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants