TestPlan: check for bad/orphaned tiny-tests #5011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes Cassandane check for various bad tiny-tests conditions at startup. This is mostly useful for detecting mistakes while backporting changes to older versions that don't have tiny tests at all, or don't use them as much as as master does. It might also be helpful when implementing new tiny-tests suites if you're not just converting an existing suite using the tool.
It complains about:
* test suites that try to Cassandane::Tiny::Loader a nonexistent directory
* multiple test suites that Cassandane::Tiny::Loader the same directory
* tiny-tests directories that no test suite calls Cassandane::Tiny::Loader on
* tiny-tests directories that don't contain any tests
It's implemented as a sanity check within Cassandane::Unit::TestPlan, not within Cassandane::Tiny, because its main purpose is to be run on the release branches where Cassandane::Tiny doesn't necessarily exist, in order to detect accidentally created tiny-tests files that will never get executed