Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use/fix custom article URL #9

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

wAmpIre
Copy link
Contributor

@wAmpIre wAmpIre commented Jan 31, 2018

All my articles have a custom URL ("URL" and "save_as") but extended_sitemap just used slug and ".html" suffix.

@coveralls
Copy link

coveralls commented Jan 31, 2018

Coverage Status

Coverage remained the same at 97.059% when pulling 6ab5e45 on wAmpIre:wampire/fix-article-custom-urls into 308b408 on dArignac:master.

@dArignac
Copy link
Owner

Hi @wAmpIre ,

thank you for the pull request!

If I understand correct, you use the ARTICLE_URL and ARTICLE_SAVE_AS settings, right?

To get your fix into production, one needs to adjust the tests, as they currently do not cover this variant.

@dArignac dArignac merged commit f136e3f into dArignac:master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants