Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support latest as a version and use it as the default input #115

Merged
merged 1 commit into from
Apr 5, 2024
Merged

feat: support latest as a version and use it as the default input #115

merged 1 commit into from
Apr 5, 2024

Conversation

purpleclay
Copy link
Contributor

closes #114

@purpleclay
Copy link
Contributor Author

This change has the added benefit of not needing to keep this repository in sync with each dagger release.

@jedevc
Copy link
Member

jedevc commented Apr 4, 2024

cc @gerhard

One thing I do like about the current setup is that if you pin this repo to a specific version/tag then it forces a specific dagger version - instead of needing to track multiple versions.

That said, I've seen latest as a pattern as well, specifically with the docker build actions - so maybe this is also viable.

@gerhard
Copy link
Member

gerhard commented Apr 4, 2024

Thanks for contributing this @purpleclay!

The problem with defaulting to latest is that we could break pipelines out of the blue. 0.8.0 had several breaking changes, 0.9.0 had a few & both 0.10.0 & 0.11.0 changed fundamental aspects in how the CLI & the Engine work together.

I am all for adding latest as an explicit version value. Would that work @purpleclay?

@purpleclay
Copy link
Contributor Author

Thanks for contributing this @purpleclay!

The problem with defaulting to latest is that we could break pipelines out of the blue. 0.8.0 had several breaking changes, 0.9.0 had a few & both 0.10.0 & 0.11.0 changed fundamental aspects in how the CLI & the Engine work together.

I am all for adding latest as an explicit version value. Would that work @purpleclay?

@gerhard happy to make that change 👍

Signed-off-by: purpleclay <purpleclaygh@gmail.com>
@purpleclay
Copy link
Contributor Author

@gerhard I have made those changes now

@gerhard
Copy link
Member

gerhard commented Apr 5, 2024

Looking at this now.

Copy link
Member

@gerhard gerhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚀

@gerhard gerhard merged commit 6cec00f into dagger:main Apr 5, 2024
2 checks passed
@gerhard
Copy link
Member

gerhard commented Apr 5, 2024

Thank you @purpleclay 💪

This change is now available in the updated v5 as well as the new v5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Support latest as the default option for the version input
3 participants