Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with tab expansion and non-English file names #64

Closed
haacked opened this issue Jul 16, 2012 · 5 comments · Fixed by #403
Closed

Issue with tab expansion and non-English file names #64

haacked opened this issue Jul 16, 2012 · 5 comments · Fixed by #403

Comments

@haacked
Copy link
Contributor

haacked commented Jul 16, 2012

Repro steps:

  1. touch 慣用音.txt
  2. git add {tab}

Expected: it expands the filename.
Actual: it expands to:

git add "\346\205\243\347\224\250\351\237\263.txt"

That wouldn't be a problem except it doesn't work.

  1. git config core.quotepath true
  2. git add {tab}

Result:

@dahlbyk
Copy link
Owner

dahlbyk commented Jul 21, 2012

The good news is using libgit2sharp fixes this. The bad news is that libgit2sharp integration isn't quite where it needs to be.

I'll see what I can do until then...

@dahlbyk
Copy link
Owner

dahlbyk commented Jul 21, 2012

It appears to work by adding -c core.quotepath=false to the git status command, but PowerShell is treating the command output differently when assigned to a variable (or piped to anything):

[master +1 ~0 -0 !]> git -c core.quotepath=false status -sb
## master
?? 慣用音.txt
[master +1 ~0 -0 !]> $status = git -c core.quotepath=false status -sb; $status
## master
?? 慣用音.txt

Setting $OutputEncoding to various values has not seemed to help.

lei-yu-wdfc pushed a commit to lei-yu-wdfc/posh-git that referenced this issue Aug 31, 2012
@haacked
Copy link
Contributor Author

haacked commented Dec 18, 2013

Should I close this as "won't fix"?

@dahlbyk
Copy link
Owner

dahlbyk commented Dec 18, 2013

Or I could mark it up-for-grabs if someone really cares to dive in. Maybe 2014 will be the year that posh-git jumps to libgit2?

@dahlbyk
Copy link
Owner

dahlbyk commented Feb 6, 2017

It appears to work by adding -c core.quotepath=false to the git status command, but PowerShell is treating the command output differently when assigned to a variable (or piped to anything).

I had completely forgotten about this particular issue, but we fixed the output encoding with #359 and #397. #403 should do the rest.

@dahlbyk dahlbyk added this to the v0.7 milestone Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants