Speed up Get-GitStatus #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes shouldn't change the core logic of Get-GitStatus, they are simply avoiding some performance problems in PowerShell. Briefly, the changes include: * Avoid array addition by using List[string] * Use the looping capability of the switch statement * Use break/continue to avoid testing switch conditions * Use a custom implementation of Select -Unique * Avoid calling dbg if it would do nothing I tested these changes in a repo 5000 files staged: Before: 3.33s After: 0.15s
dahlbyk
reviewed
Dec 31, 2016
| $working = New-Object PSObject @(,@($workingPaths | ?{ $_ } | Select -Unique)) | | ||
| # | ||
| # This collection is used twice, so create the array just once | ||
| $filesAdded = $filesAdded.ToArray() |
There was a problem hiding this comment.
Delayed review... I'm curious why $filesAdded is special here? I don't see anything about its usage below that would be problematic.
There was a problem hiding this comment.
I didn't want to change anything, so I create a single array for the two places this is used. All the others are used just once, so inline was cleaner.
This was referenced Dec 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes shouldn't change the core logic of Get-GitStatus,
they are simply avoiding some performance problems in PowerShell.
Briefly, the changes include:
I tested these changes in a repo 5000 files staged:
Before: 3.33s
After: 0.15s