Worth adding optional timing output to def prompt? #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is enabled with `$GitPromptSettings.DefaultPromptEnableTiming=$true` and then the prompt function outputs `~\GitHub\rkeithhill\posh-git [rkeithhill/enable-default-prompt-timing +0 ~2 -0 !] 55 mS>`. It also occurred to me that the GitPromptSettings should be prefixed "DefaultPrompt" so folks don't think they apply to their own custom prompt functions. I'm not entirely sure this is worth it but I could see it coming in handy to get "hard" perf data from users of the default prompt. If we decide not to go with this PR, I still think we should consider adding the "Default" prefix to the existing two Prompt*Suffix settings. In the VSCode dir on my machine (status equiv to origin), the prompt takes 150 mS. VSCode has 6466 files in the repo.
"123 mS" => "123ms"
|
I like the idea. Added commit to compress the display: |
rkeithhill
commented
Jan 17, 2017
| @@ -92,7 +92,7 @@ if (!$currentPromptDef -or ($currentPromptDef -eq $defaultPromptDef)) { | |||
| if ($GitPromptSettings.DefaultPromptEnableTiming) { | |||
| $sw.Stop() | |||
| $elapsed = $sw.ElapsedMilliseconds | |||
| Write-Host " $elapsed mS" -NoNewline | |||
| Write-Host " $($elapsed)ms" -NoNewline | |||
There was a problem hiding this comment.
Works for me. You can simplify that a bit " ${elapsed}ms". In interpolated strings in PowerShell, you can delineate variable names from other text with ${<variable-name>}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is enabled with
$GitPromptSettings.DefaultPromptEnableTiming=$trueand then the prompt function outputs~\GitHub\rkeithhill\posh-git [rkeithhill/enable-default-prompt-timing +0 ~2 -0 !] 55 mS>.It also occurred to me that the GitPromptSettings should be prefixed "DefaultPrompt" so folks don't think they apply to their own custom prompt functions.
I'm not entirely sure this is worth it but I could see it coming in handy to get "hard" perf data from users of the default prompt. If we decide not to go with this PR, I still think we should consider adding the "Default" prefix to the existing two Prompt*Suffix settings.
In the VSCode dir on my machine (status equiv to origin), the prompt takes 150 mS. VSCode has 6466 files in the repo.