Changed Android Auto/Wear settings to show rewind/fast forward icons correctly #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the Android Auto and Wear controls to show rewind/fast forward when appropriate instead of only ever showing previous/next. This will better match the Now Playing fragment and notifications.
An interesting note in this: when Auto/Wear support was first introduced in 2015, the previous/next button would not show if the song playing was the first/last item in the queue, respectively. Since no other section that has play/pause/skip acts in the same manner, it was actually an outlier in this behavior. The interesting part is that the commit was to remove "useless" buttons, but the previous button was still useful, given that it could skip back to the beginning of a track. Either way, this will bring it in line with the other changes I've made in #940 and #941.
Meant to work with code submitted in PR #940, specifically the changes in DownloadService. Just like in #941, if that PR is not merged but you do want this one merged, I will add a commit to make that change so previous/next always go previous/next instead of going rewind/fastforward in some cases.