-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
includeContext option description incorrectly refers to notes tag #95
Comments
I found this issue today. I think the The |
@co-dax , @doggy8088 I'm not sure I understand your point(s).
Or this this about something else entirely? |
@daniel-sc Please check my repo: https://github.com/doggy8088/ng-i18n-demo/tree/ng-extract-i18n-merge At first, check this commit: doggy8088/ng-i18n-demo@a45ff6d?diff=unified&w=0 After I run I think the |
@daniel-sc I was using version 1.4 and with that version it used to work as I described above. I have just upgraded to version 2.9.1 and now it works as described by @doggy8088 just above. I thnk @doggy8088 is right in his last comment on how it should be working. |
@doggy8088 @co-dax ok, finally I got your point :) |
…Add new config to explicitly remove them. fixes #95
@daniel-sc Good job! 😃 Thanks! 👍 |
At the following link https://github.com/daniel-sc/ng-extract-i18n-merge?tab=readme-ov-file#configuration the docs are saying the following in the context of
includeContext
option:...but the
note
tag in preserved in the destination/merged file which should be the correct behaviour sincenote
tag in outside ofcontext-group
to which the propertyincludeContext
is (at least should be) referring.So I would say that the excerpt:
...should be removed from the link I reported above.
The text was updated successfully, but these errors were encountered: