Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bnaf Issue #103

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Bnaf Issue #103

merged 3 commits into from
Oct 4, 2023

Conversation

danielward27
Copy link
Owner

Fixes #102, by using a LeakyTanh bijection, that defaults to a linear transform above or below max_val. Happy for more investigation/discussions, but this seems a reasonable fix for now.

Breaking changes:

  • The activation for BlockAutoregressiveNetwork no longer needs a specific form, and instead can be any (potentially trainable) callable or scalar unconditional bijection.
  • Renaming of TanhLinearTails to LeakyTanh could break users code (e.g. if subclassing TanhLinearTails, or explicitly relying on the class name).

@danielward27 danielward27 merged commit 1de1fc3 into main Oct 4, 2023
1 check passed
@danielward27 danielward27 deleted the bnaf_bug branch October 4, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockNeuralAutoregressiveFlow not initially normalized correctly
1 participant