Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting video bigger than 2GB #122

Closed
chyj4747 opened this issue Mar 11, 2017 · 1 comment
Closed

Supporting video bigger than 2GB #122

chyj4747 opened this issue Mar 11, 2017 · 1 comment
Labels
Milestone

Comments

@chyj4747
Copy link

When I use this lib to cache video where size is bigger than 2GB, it can only cache 2GB data and then all threads(includes main ui thread) are stopped. So I changed 'int' to 'long' of this lib, it seems to work well(the file cached seems ok), but still, all threads are stopped.

@danikula danikula added the bug label Mar 24, 2017
@danikula danikula changed the title Does not support video bigger than 2GB? Supporting video bigger than 2GB Mar 24, 2017
@danikula
Copy link
Owner

danikula commented Mar 24, 2017

@chyj4747 You are right. AndroidVideoCache uses type int in Source and Cache interfaces instead of long. So videos bigger than 2^31 bytes (2GB) will fail :( . We really must use long type.

@danikula danikula added this to the 2.7.0 milestone Apr 18, 2017
danikula added a commit that referenced this issue Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants