Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

program dying due to stack overflow doesn't call signal handlers #2424

Closed
dankamongmen opened this issue Dec 6, 2021 · 3 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dankamongmen
Copy link
Owner

I had a bug in ncman which resulted in an infinite recursion. Upon receiving its SIGSEGV, the terminal was not restored to its original mode. The SIGSEGV handler never appeared to be called. I think establishing an alternate signal handler stack early on will work around this problem; we should probably do so.

@dankamongmen dankamongmen added the bug Something isn't working label Dec 6, 2021
@dankamongmen dankamongmen added this to the 4.0.0 milestone Dec 6, 2021
@dankamongmen dankamongmen self-assigned this Dec 6, 2021
@dankamongmen
Copy link
Owner Author

Hrmmm, I'm not sure sigaltstack() is process-wide; it might just be for the calling thread =.

@dankamongmen
Copy link
Owner Author

yeah, it's per-thread, urk. well, we can't control everyone else's threads, but we can handle our own, i suppose.

@dankamongmen
Copy link
Owner Author

done, tested, works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant