Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support blending with default colors #2433

Closed
dankamongmen opened this issue Dec 6, 2021 · 3 comments · Fixed by #2488
Closed

support blending with default colors #2433

dankamongmen opened this issue Dec 6, 2021 · 3 comments · Fixed by #2488
Assignees
@dankamongmen
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
3.1.0

Comments

@dankamongmen
Copy link
Owner

I don't think we currently support NCALPHA_HIGHCONTRAST when the background is the default color, but now that we ask the terminal for that value, we could. Do so. Probably need to update the documentation somewhere. See #2432.
@dankamongmen dankamongmen added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 6, 2021
@dankamongmen dankamongmen added this to the 4.0.0 milestone Dec 6, 2021
@dankamongmen dankamongmen self-assigned this Dec 6, 2021
@dankamongmen dankamongmen mentioned this issue Dec 16, 2021
Closed
@dankamongmen dankamongmen modified the milestones: 4.0.0, 3.1.0 Dec 17, 2021
@dankamongmen
Copy link
Owner Author

this already works, actually (just tested in tfman, see #2480). it's just blending that doesn't work with default backgrounds.

this is annoying to bring into channels_blend() because you need to use either the fg or the bg, but the two inline wrappers can solve that trivially enough...

@dankamongmen dankamongmen changed the title support HIGHCONTRAST atop default background support blending with default colors Dec 18, 2021
dankamongmen added a commit that referenced this issue Dec 19, 2021
@dankamongmen
[channels_blend] support fully general blending #2433
3245ad3
@dankamongmen
Copy link
Owner Author

we now have a fully general channels_blend(). we need to update the unit tests. also, i think we should special-case things so that default-on-default equals true default, not default rgb, and that palette N1-on-palette N2 (N1==N2) yields palette N1, not palette RGB.

dankamongmen added a commit that referenced this issue Dec 19, 2021
@dankamongmen
[channels_blend] update unit tests for general blender #2433
c377de7
@dankamongmen
Copy link
Owner Author

unit tests are fixed up, and i made the changes specified above.

@dankamongmen dankamongmen mentioned this issue Dec 19, 2021
Merged
dankamongmen added a commit that referenced this issue Dec 19, 2021
@dankamongmen
[channels_blend] support fully general blending #2433
2d7c2ea
dankamongmen added a commit that referenced this issue Dec 19, 2021
@dankamongmen
[channels_blend] update unit tests for general blender #2433
094c8c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Fully general blender dankamongmen/notcurses
1 participant
@dankamongmen