Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

menu items using modifiers are broken #2554

Closed
dankamongmen opened this issue Jan 12, 2022 · 4 comments
Closed

menu items using modifiers are broken #2554

dankamongmen opened this issue Jan 12, 2022 · 4 comments
Assignees
@dankamongmen
Labels
bug Something isn't working input readin' dem bytes
Milestone
3.1.0

Comments

@dankamongmen
Copy link
Owner

Our recent changes to ncinput appear to have broken ncmenu. There, we specify with an ncinput the various keyboard shortcuts for sections and items. Presumably we're not matching modifier, as they're all going to be using the deprecated explicit modifiers.

  • bring up to speed all ncmenu users in the tree
  • fix ncinput_equals_p()
@dankamongmen dankamongmen added bug Something isn't working input readin' dem bytes labels Jan 12, 2022
@dankamongmen dankamongmen added this to the 3.1.0 milestone Jan 12, 2022
@dankamongmen dankamongmen self-assigned this Jan 12, 2022
@dankamongmen
Copy link
Owner Author

oh, i bet this is happening in kitty because we switched to NCKEY_EV_PRESS from NCKEY_EV_UNKNOWN, duh.

@dankamongmen
Copy link
Owner Author

yep, it's working in xterm, ok. and we haven't made a release with the move to NCTYPE_PRESS, good good good, no releases with broken-ass menus.

@dankamongmen
Copy link
Owner Author

hrmmm maybe ncinput_equal_p() ought consider UNKNOWN and PRESS to be the same thing?

dankamongmen added a commit that referenced this issue Jan 12, 2022
@dankamongmen
[ncinput_equals] consider UNKNOWN == PRESS #2554
15e2c6e
@dankamongmen
Copy link
Owner Author

alright, everything seems to be working now, glad we caught this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bug Something isn't working input readin' dem bytes
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
1 participant
@dankamongmen