Don't misuse KeyError for the custom names function.
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 2 2
Lines 1041 1063 +22
=======================================
+ Hits 1040 1062 +22
Misses 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kurtmckee
suggested changes
Jun 19, 2024
| The two default names that are provided are ``True`` and ``False``. So if you want to provide your own names, but want ``True`` and ``False`` to keep working, either provide them yourself, or ``.copy()`` and ``.update`` the ``DEFAULT_NAMES``. (See functions example above). | ||
| In general, when it attempts to find a variable by name, if it cannot find one, | ||
| then it will look in the ``functions`` for a function of that name. If you want your name handler | ||
| function to return a "I can't find that name!", then it should raise a ``simpleeval.NameNotDefined`` |
There was a problem hiding this comment.
Suggested change
| function to return a "I can't find that name!", then it should raise a ``simpleeval.NameNotDefined`` | |
| function to return an "I can't find that name!", then it should raise a ``simpleeval.NameNotDefined`` |
| function to return a "I can't find that name!", then it should raise a ``simpleeval.NameNotDefined`` | ||
| exception. Eg: | ||
|
|
||
| .. code-block:: python |
There was a problem hiding this comment.
REPL sessions like this should use pycon as the syntax highlighting.
Suggested change
| .. code-block:: python | |
| .. code-block:: pycon |
| >>> simple_eval('a + b', names=name_handler, functions={'b': 100}) | ||
| 121 | ||
|
|
||
| (Note: in that example, putting a number directly into the functions dict was done just to |
There was a problem hiding this comment.
Suggested change
| (Note: in that example, putting a number directly into the functions dict was done just to | |
| (Note: in that example, putting a number directly into the ``functions`` dict was done just to |
| @@ -526,24 +526,30 @@ def _eval_name(self, node): | |||
| try: | |||
| # This happens at least for slicing | |||
| # This is a safe thing to do because it is impossible | |||
| # that there is a true exression assigning to none | |||
| # that there is a true expression assigning to none | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #94
Makes
KeyErrorand stuff a bit more friendly for users using a customnameslookup.If their
namesfunction throws aKeyErrorunexpectedly, it was getting caught incorrectly.This expands the documentation & makes it so that people using a custom
namesresolver should deliberately only throw asimpleeval.NameNotDefined, other exceptions would be raised correctly.