Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly validate evaluation expression input #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PPakalns
Copy link

  • There must be exactly one statement in input
  • Given statement must be an expression (assignment, augmented assignment, etc. are not allowed)

Resolves #58 #65 #67

@pep8speaks
Copy link

pep8speaks commented Dec 12, 2019

Hello @PPakalns! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-12 10:30:39 UTC

@coveralls
Copy link

coveralls commented Dec 12, 2019

Coverage Status

Coverage increased (+2.6%) to 99.602% when pulling 7ef2214 on PPakalns:master into 66b04c9 on danthedeckie:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.7%) to 98.69% when pulling e3b4ab5 on PPakalns:master into 66b04c9 on danthedeckie:master.

* There must be exactly one statement in input
* Given statement must be an expression (assignment, augmented
  assignment, etc. are not allowed)
@PPakalns
Copy link
Author

I believe that these issues found by CodeFactor can be fixed in other pull request as I did not introduce them or I used the same style that was already used by this library.
If you do not agree I can of course fix these reported errors.

@jeffreyscottgraham
Copy link

Is this issue dead?

@PPakalns
Copy link
Author

PPakalns commented Jan 25, 2021

@jeffreyscottgraham
There are users that are already dependent on the way how this library is implemented. See this comment and the whole thread.

Looks like 2.0 version of this library needs to be created. If someone needs additional functionality, then new fork of this library, probably, must be created because the activity on this project is very low.

@danthedeckie danthedeckie added this to the 2.0-alpha milestone Feb 17, 2023
@kurtmckee
Copy link
Contributor

@danthedeckie I recommend closing this PR due to its age.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise error when multi line expression is passed for evaluation
6 participants