Add a check for Jenkins results. #13533

ashleypittman · 2023-12-21T21:15:11Z

Skip-build: true

Required-githooks: true

Signed-off-by: Ashley Pittman ashley.m.pittman@intel.com

github-actions · 2023-12-21T21:15:30Z

Bug-tracker data:
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Add

daosbuild1 · 2023-12-21T21:17:12Z

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13533/1/execution/node/123/log

daosbuild1 · 2023-12-21T21:19:07Z

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13533/2/execution/node/125/log

daosbuild1 · 2023-12-21T21:46:37Z

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13533/3/execution/node/125/log

daosbuild1 · 2023-12-21T21:54:40Z

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13533/5/execution/node/124/log

daosbuild1 · 2023-12-21T21:56:42Z

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13533/6/execution/node/125/log

Required-githooks: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

Required-githooks: true

Skip-build: true Required-githooks: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

daltonbohning · 2024-01-04T15:25:18Z

ci/jenkins_status.py

@@ -0,0 +1,212 @@
+#!/usr/bin/env python


This is probably okay, but some distros point python -> python2 so personally I tend to use python3 here

I hope we're beyond that now!

Hopefully, but some older (still supported) distros still use python2 by default last I checked. Also, some distros don't symlink python at all. E.g.

$ cat /etc/os-release NAME="SLES" VERSION="15-SP4" VERSION_ID="15.4" PRETTY_NAME="SUSE Linux Enterprise Server 15 SP4" ID="sles" ID_LIKE="suse" ANSI_COLOR="0;32" CPE_NAME="cpe:/o:suse:sles:15:sp4" DOCUMENTATION_URL="https://documentation.suse.com/" $ which python which: no python in ... $ which python3 /usr/bin/python3

daltonbohning · 2024-01-04T15:26:38Z

ci/jenkins_status.py

+        name = data["name"]
+        if "-" in name:
+            try:
+                (num, full) = name.split("-", 1)
+                test_num = int(num)
+                if full[-5] == "-":
+                    full = full[:-5]
+                name = f"{full} ({test_num})"


What does the original data["name"] look like?

this is the weird 8 digits of sha hash at the end of the PR name which is making matching fail.

daltonbohning · 2024-01-04T15:27:07Z

ci/jenkins_status.py

+        self.skipped = False
+        self.passed = False
+        self.failed = False
+        assert data["status"] in ("PASSED", "FIXED", "SKIPPED", "FAILED", "REGRESSION")


Maybe better to gracefully handle?

For an internal script I'm OK with this, if there is another status then we want to know about it so we handle it properly. As we're scraping Jenkins then we can stress-test this code against previous builds.

The problem with assert is that the entire script will fail without much debug info.

daltonbohning · 2024-01-04T15:29:57Z

ci/jenkins_status.py

+
+    failed = []
+
+    assert not jdata["testActions"]


I could just remove this, it was me trying to understand the output.

daltonbohning · 2024-01-04T15:32:20Z

ci/jenkins_status.py

+        for test in failed:
+            all_failed.add(test)


JFYI you can add a list to another list like this:

>>> list1 = [1,2,3] >>> list2 = [4,5,6] >>> list1.extend(list2) >>> list1 [1, 2, 3, 4, 5, 6]

all_failed is a set, not list.

Ah, then JFYI

>>> set1 = set([1,2,3]) >>> list2 = [4,5,6] >>> set1.update(list2) >>> set1 {1, 2, 3, 4, 5, 6}

Skip-build: true Required-githooks: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

Required-githooks: true

Required-githooks: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

daosbuild1 · 2024-01-15T18:15:31Z

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13533/16/execution/node/1479/log

daosbuild1 · 2024-01-15T18:20:04Z

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13533/16/testReport/

daosbuild1 · 2024-01-15T20:18:48Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13533/16/execution/node/1417/log

ashleypittman force-pushed the amd/daily-query branch from 3559db1 to 0ea196f Compare December 21, 2023 21:17

ashleypittman force-pushed the amd/daily-query branch from 0ea196f to 4b2565c Compare December 21, 2023 21:44

ashleypittman force-pushed the amd/daily-query branch 2 times, most recently from decef3f to bd04920 Compare December 21, 2023 21:53

ashleypittman force-pushed the amd/daily-query branch from bd04920 to f6e5f57 Compare December 21, 2023 21:54

ashleypittman force-pushed the amd/daily-query branch 2 times, most recently from 585d4bf to c5c6b02 Compare December 21, 2023 22:04

Add a check for Jenkins results.

0ab2971

Required-githooks: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

ashleypittman force-pushed the amd/daily-query branch from c5c6b02 to 0ab2971 Compare December 21, 2023 22:18

ashleypittman added 3 commits January 2, 2024 10:40

Check all three landing jobs and tidy up code.

bfcea4a

Required-githooks: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

Merge branch 'master' into amd/daily-query

f1f21c6

Required-githooks: true

Stop after explaining tests.

b605e31

Skip-build: true Required-githooks: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

daltonbohning reviewed Jan 4, 2024

View reviewed changes

ashleypittman added 2 commits January 4, 2024 16:50

Add a --target release/2.4 option.

111f5b1

Skip-build: true Required-githooks: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

Add more.

9f751b9

Skip-build: true Required-githooks: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

jolivier23 previously approved these changes Jan 9, 2024

View reviewed changes

Catch the cases where PR builds have not completed or do not exist.

198d8b4

Skip-build: true Required-githooks: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

ashleypittman dismissed jolivier23’s stale review via 198d8b4 January 15, 2024 12:09

ashleypittman added 2 commits January 15, 2024 12:18

Merge branch 'master' into amd/daily-query

d851c00

Required-githooks: true

Fix spelling.

38ab23c

Required-githooks: true Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

ashleypittman closed this Feb 26, 2024

ashleypittman deleted the amd/daily-query branch February 26, 2024 11:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a check for Jenkins results. #13533

Add a check for Jenkins results. #13533

ashleypittman commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

daosbuild1 commented Dec 21, 2023

daosbuild1 commented Dec 21, 2023

daosbuild1 commented Dec 21, 2023

daosbuild1 commented Dec 21, 2023

daosbuild1 commented Dec 21, 2023

daltonbohning Jan 4, 2024

ashleypittman Jan 4, 2024

daltonbohning Jan 4, 2024

daltonbohning Jan 4, 2024

ashleypittman Jan 4, 2024

daltonbohning Jan 4, 2024

ashleypittman Jan 4, 2024

daltonbohning Jan 4, 2024

daltonbohning Jan 4, 2024

ashleypittman Jan 4, 2024

daltonbohning Jan 4, 2024

ashleypittman Jan 4, 2024

daltonbohning Jan 4, 2024

daosbuild1 commented Jan 15, 2024

daosbuild1 commented Jan 15, 2024

daosbuild1 commented Jan 15, 2024

Add a check for Jenkins results. #13533

Add a check for Jenkins results. #13533

Conversation

ashleypittman commented Dec 21, 2023

github-actions bot commented Dec 21, 2023

daosbuild1 commented Dec 21, 2023

daosbuild1 commented Dec 21, 2023

daosbuild1 commented Dec 21, 2023

daosbuild1 commented Dec 21, 2023

daosbuild1 commented Dec 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Jan 15, 2024

daosbuild1 commented Jan 15, 2024

daosbuild1 commented Jan 15, 2024