Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15517 rebuild: refine lock handling for rpt list #14064

Merged
merged 2 commits into from
Apr 3, 2024
Merged

DAOS-15517 rebuild: refine lock handling for rpt list #14064

merged 2 commits into from
Apr 3, 2024

Conversation

liuxuezhao
Copy link
Contributor

@liuxuezhao liuxuezhao commented Mar 26, 2024 •
edited
Loading

Originally the rpt list only be accessible by system XS, so need not lock.
But commit 61e1334 (DAOS-14010 rebuild: add delay rebuild #13357) changed
that VOS tgt XS also can access it so it is not safe anymore.
This patch added minimal necessary lock to protect it.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@liuxuezhao liuxuezhao requested review from a team as code owners March 26, 2024 10:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

Ticket title is 'soak online harasser: Seg fault - Assertion 'dss_get_module_info()->dmi_xs_id == 0' '
Status is 'In Review'
Labels: '2.6.0tb1,soak,triaged'
https://daosio.atlassian.net/browse/DAOS-15517

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14064/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14064/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14064/2/testReport/

@liuxuezhao liuxuezhao changed the title DAOS-15517 rebuild: refine lock handling for rebuild_tgt_pool_tracker DAOS-15517 rebuild: refine lock handling for rpt list Mar 27, 2024
@liuxuezhao liuxuezhao requested review from NiuYawei, Nasf-Fan and kccain and removed request for a team March 28, 2024 08:25
NiuYawei
NiuYawei requested changes Mar 29, 2024
View reviewed changes
src/rebuild/srv.c Show resolved Hide resolved
src/rebuild/srv.c Show resolved Hide resolved
@liuxuezhao
DAOS-15517 rebuild: refine lock handling for rpt list
577cf4b 
Originally the rpt list only be accessible by system XS, so need not lock.
But commit 61e1334 (DAOS-14010 rebuild: add delay rebuild #13357)
changed that VOS tgt XS also can access rpt and rpt list so it is
not safe anymore.
This patch added minimal necessary lock to protect it.

Required-githooks: true
Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
@liuxuezhao liuxuezhao force-pushed the lxz/rpt_lock_fix branch 2 times, most recently from 7bc1a24 to d389588 Compare March 29, 2024 03:17
@liuxuezhao
DAOS-15517 rebuild: address Niu's comment
2c86b8c 
Required-githooks: true

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
@liuxuezhao liuxuezhao requested a review from a team April 3, 2024 01:22
@NiuYawei NiuYawei merged commit 4d9323b into master Apr 3, 2024
48 of 49 checks passed
@NiuYawei NiuYawei deleted the lxz/rpt_lock_fix branch April 3, 2024 02:07
jolivier23 pushed a commit that referenced this pull request Jul 2, 2024
@liuxuezhao @jolivier23
b/349170185 Backport fixes
6087823 
DAOS-16039 object: fix EC aggregation wrong peer address (#14593)
DAOS-16009 rebuild: fix O_TRUNC file size related handling
DAOS-15056 rebuild: add rpt to the rgt list properly (#13862)
DAOS-15517 rebuild: refine lock handling for rpt list (#14064)
DAOS-13812 container: fix destroy vs lookup (#12757)
DAOS-15627 dtx: redunce stack usage for DTX resync to avoid overflow (#14189)
DAOS-14845 rebuild: do not wait for EC agg for reclaim (#13610)

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Wang, Di <wddi218@gmail.com>
Signed-off-by: Di Wang <di.wang@intel.com>
Signed-off-by: Wang Shilong <shilong.wang@intel.com>
Signed-off-by: Fan Yong <fan.yong@intel.com>
@jolivier23 jolivier23 mentioned this pull request Jul 2, 2024
Merged
18 tasks
jolivier23 added a commit that referenced this pull request Jul 3, 2024
@jolivier23
b/349170185 Backport fixes (#14680)
5b9557b 
DAOS-16039 object: fix EC aggregation wrong peer address (#14593)
DAOS-16009 rebuild: fix O_TRUNC file size related handling
DAOS-15056 rebuild: add rpt to the rgt list properly (#13862)
DAOS-15517 rebuild: refine lock handling for rpt list (#14064)
DAOS-13812 container: fix destroy vs lookup (#12757)
DAOS-15627 dtx: redunce stack usage for DTX resync to avoid overflow (#14189)
DAOS-14845 rebuild: do not wait for EC agg for reclaim (#13610)

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Wang, Di <wddi218@gmail.com>
Signed-off-by: Di Wang <di.wang@intel.com>
Signed-off-by: Wang Shilong <shilong.wang@intel.com>
Signed-off-by: Fan Yong <fan.yong@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiuYawei NiuYawei NiuYawei approved these changes

@Nasf-Fan Nasf-Fan Nasf-Fan approved these changes

@kccain kccain kccain approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liuxuezhao @daosbuild1 @NiuYawei @Nasf-Fan @kccain