Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15672 rebuild: Fix pool destroy hangs #14183

Merged
merged 1 commit into from
Apr 22, 2024
Merged

DAOS-15672 rebuild: Fix pool destroy hangs #14183

merged 1 commit into from
Apr 22, 2024

Conversation

liw
Copy link
Contributor

@liw liw commented Apr 18, 2024

See the Jira ticket for the long story. When releasing resources, for instance, for stopping a pool, we should attempt on all targets, because the latest version of the pool map may differ from the version used to acquire the resources. (And in some cases, we no longer have the original pool map version in the context.)

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

Ticket title is 'Couldn't destroy a pool because of outstanding ds_pool_child references due to migrate_pool_tls leaks'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-15672

liuxuezhao
liuxuezhao previously approved these changes Apr 18, 2024
View reviewed changes
@liw
DAOS-15672 rebuild: Fix pool destroy hangs
6e7ed01 
See the Jira ticket for the long story. When releasing resources, for
instance, for stopping a pool, we should attempt on all targets, because
the latest version of the pool map may differ from the version used to
acquire the resources. (And in some cases, we no longer have the
original pool map version in the context.)

Signed-off-by: Li Wei <wei.g.li@intel.com>
Required-githooks: true
@liw
Copy link
Contributor Author

liw commented Apr 18, 2024

Removed the container change because it is already in #14108.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14183/2/execution/node/1452/log

@liw
Copy link
Contributor Author

liw commented Apr 21, 2024

daos_test/degraded: DAOS-15519 (the fix landed after this PR was created)

@liw liw marked this pull request as ready for review April 21, 2024 23:53
@liw liw requested review from a team as code owners April 21, 2024 23:53
@liw liw requested a review from a team April 21, 2024 23:53
@liw liw added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Apr 21, 2024
@mchaarawi mchaarawi merged commit 64dcbc7 into master Apr 22, 2024
49 of 51 checks passed
@mchaarawi mchaarawi deleted the liw/mpt-leak branch April 22, 2024 00:52
@liw liw mentioned this pull request Jun 12, 2024
Merged
18 tasks
jolivier23 pushed a commit that referenced this pull request Jun 13, 2024
@liw @jolivier23
DAOS-15672 rebuild: Fix pool destroy hangs (#14183)
679d381 
See the Jira ticket for the long story. When releasing resources, for
instance, for stopping a pool, we should attempt on all targets, because
the latest version of the pool map may differ from the version used to
acquire the resources. (And in some cases, we no longer have the
original pool map version in the context.)

Required-githooks: true

Change-Id: I363fbfefae01dd75cc07ded31a2e5b7033f01610
Signed-off-by: Li Wei <wei.g.li@intel.com>
jolivier23 added a commit that referenced this pull request Jun 17, 2024
@jolivier23
Backports to address b/336317519 (#14561)
937b5a3 
DAOS-14679 pool: Report on stopping sp_stopping (#14374)
DAOS-15514 container: fix container destroy failure (#14108)
DAOS-15672 rebuild: Fix pool destroy hangs (#14183)
DAOS-15145 pool: add pool collective function (#13764)
*DAOS-14105 object: collectively punch object (#13493)

partial backport, just the bitmap function

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Li Wei <wei.g.li@intel.com>
Signed-off-by: Wang Shilong <shilong.wang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuxuezhao liuxuezhao liuxuezhao approved these changes

@wangshilong wangshilong wangshilong approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liw @daosbuild1 @liuxuezhao @wangshilong @mchaarawi