Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15799 build: Add libsanitize #14485

Closed
wants to merge 2 commits into from

Conversation

knard-intel
Copy link
Contributor

@knard-intel knard-intel commented May 31, 2024

WARNING: This PR is not intended to be merged, but just to build rpms allowing to debug stack bumping issue of the ticket DAOS-15799.

Description

Add libsanitize for debugging stack smashing occuring on LRZ servers.

Skip-test: true
Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

github-actions bot commented May 31, 2024

Bug-tracker data:
Ticket title is 'LRZ: engine coredumps 2024/05/03 10:18:17 with UCX 1.16'
Status is 'In Progress'
Labels: 'LRZ,scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-15799

@knard-intel knard-intel force-pushed the ckochhof/fix/v2.4.2-rc3/daos-15799 branch 6 times, most recently from 49ff437 to d38afa0 Compare June 6, 2024 12:47
Add libsanitize for debugging stack smashing occuring on LRZ servers.

WARNIN: When libasan is activated the dlopen is not working properly,
	and the path of the libraries have to be explicitly defined.
	More details on tis can be found at
	https://sourceware.org/bugzilla/show_bug.cgi?id=25114

Skip-test: true
Required-githooks: true

Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@intel.com>
@knard-intel knard-intel force-pushed the ckochhof/fix/v2.4.2-rc3/daos-15799 branch 7 times, most recently from 58ff43d to 855d80e Compare June 10, 2024 08:16
Version with protected stack and address sanitizer.

Skip-test: true
Required-githooks: true

Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@intel.com>
opts.Add(BoolVariable('STACK_MMAP', 'Allocate ABT ULTs stacks with mmap()', 0))
opts.Add(BoolVariable('STACK_MMAP', 'Allocate ABT ULTs stacks with mmap()', 1))
opts.Add(BoolVariable('ADDRESS_SANITIZER',
'Instrument C code with the Address Sanitizer library', 1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would SANITIZER=<address|thread|...> be more economical? Or, even COMPILER_FEAT=<asan|tsan|...>, but I'm not sure if that's going too far.

print('Enabling Address Sanitizer')
# Enable Address Sanitizer, a fast memory error detector.
env.Prepend(LINKFLAGS=['-fsanitize=address'])
env.Prepend(CCFLAGS=['-fsanitize=address'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also '-fno-omit-frame-pointer' in CCFLAGS for better reports.

I found that I had to change -Wframe-larger-than=4096 to a larger value (8192 worked for me), due to the redzones added by asan.

@knard-intel knard-intel deleted the ckochhof/fix/v2.4.2-rc3/daos-15799 branch September 11, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants