Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16168 build: Ignore scons version deprecation (#14715) #14745

Closed
wants to merge 77 commits into from

DAOS-16168 build: Ignore scons version deprecation (#14715) (#14719)

509745d
Select commit
Loading
Failed to load commit list.
Closed

DAOS-16168 build: Ignore scons version deprecation (#14715) #14745

DAOS-16168 build: Ignore scons version deprecation (#14715) (#14719)
509745d
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Jul 11, 2024 in 0s

DCO

There are 35 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~77 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin jvolivie/fix_scons_2.4

Summary

Commit sha: e888c01, Author: Alexander Oganezov, Committer: Jeff Olivier; Expected "Alexander Oganezov alexander.a.oganezov@intel.com", but got "Alexander A Oganezov alexander.a.oganezov@intel.com".
Commit sha: 588e972, Author: Ashley Pittman, Committer: Jeff Olivier; The sign-off is missing.
Commit sha: 9d0a841, Author: Cedric Koch-Hofer, Committer: Jeff Olivier; Expected "Cedric Koch-Hofer 94527853+knard-intel@users.noreply.github.com", but got "Cedric Koch-Hofer cedric.koch-hofer@intel.com".
Commit sha: b9faf1c, Author: Cedric Koch-Hofer, Committer: Jeff Olivier; Expected "Cedric Koch-Hofer cedric.koch.hofer@gmail.com", but got "Cedric Koch-Hofer cedric.koch-hofer@intel.com".
Commit sha: 61d483b, Author: Cedric Koch-Hofer, Committer: Jeff Olivier; Expected "Cedric Koch-Hofer cedric.koch.hofer@gmail.com", but got "Cedric Koch-Hofer cedric.koch-hofer@intel.com".
Commit sha: c268250, Author: Cedric Koch-Hofer, Committer: Jeff Olivier; Expected "Cedric Koch-Hofer 94527853+knard-intel@users.noreply.github.com", but got "Cedric Koch-Hofer cedric.koch-hofer@intel.com".
Commit sha: 6d0abbc, Author: Colin, Committer: Jeff Olivier; The sign-off is missing.
Commit sha: cdf7e80, Author: Colin, Committer: Jeff Olivier; The sign-off is missing.
Commit sha: 4e42e39, Author: Colin Howes, Committer: Jeff Olivier; The sign-off is missing.
Commit sha: f5435a1, Author: Colin Howes, Committer: Jeff Olivier; The sign-off is missing.
Commit sha: 3108ce9, Author: Colin Howes, Committer: Jeff Olivier; The sign-off is missing.
Commit sha: dfd7211, Author: Jeff Olivier, Committer: GitHub; Expected "Jeff Olivier jeffolivier@google.com", but got "Li Wei wei.g.li@intel.com".
Commit sha: 98c953a, Author: Jeff Olivier, Committer: GitHub; Expected "Jeff Olivier jeffolivier@google.com", but got "Li Wei wei.g.li@intel.com".
Commit sha: ca43ed2, Author: Jeff Olivier, Committer: GitHub; Expected "Jeff Olivier jeffolivier@google.com", but got "Ashley Pittman ashley.m.pittman@intel.com".
Commit sha: 28d189a, Author: Jeff Olivier, Committer: GitHub; Expected "Jeff Olivier jeffolivier@google.com", but got "Niu Yawei yawei.niu@intel.com".
Commit sha: 868bf18, Author: Jeff Olivier, Committer: GitHub; Expected "Jeff Olivier jeffolivier@google.com", but got "Fan Yong fan.yong@intel.com".
Commit sha: 0f2ace7, Author: Jeff Olivier, Committer: GitHub; Can not find "Jeff Olivier jeffolivier@google.com", in ["Li Wei wei.g.li@intel.com", "Li Wei wei.g.li@intel.com"].
Commit sha: 533ce74, Author: Jeff Olivier, Committer: GitHub; Expected "Jeff Olivier jeffolivier@google.com", but got "Xuezhao Liu xuezhao.liu@intel.com".
Commit sha: ea72f97, Author: Jeff Olivier, Committer: GitHub; Expected "Jeff Olivier jeffolivier@google.com", but got "Li Wei wei.g.li@intel.com".
Commit sha: 5f96988, Author: Jeff Olivier, Committer: GitHub; Expected "Jeff Olivier jeffolivier@google.com", but got "Xuezhao Liu xuezhao.liu@intel.com".
Commit sha: 9c5c222, Author: Jeff Olivier, Committer: GitHub; Expected "Jeff Olivier jeffolivier@google.com", but got "Tomasz Gromadzki tomasz.gromadzki@intel.com".
Commit sha: 0fdd529, Author: Jeff Olivier, Committer: GitHub; Expected "Jeff Olivier jeffolivier@google.com", but got "Xuezhao Liu xuezhao.liu@intel.com".
Commit sha: 7da45c7, Author: juszhan1, Committer: GitHub; Expected "juszhan1 161389129+juszhan1@users.noreply.github.com", but got "Justin Zhang juszhan@google.com".
Commit sha: 5c7e312, Author: Margaret Lawson, Committer: Jeff Olivier; The sign-off is missing.
Commit sha: 43f0aa9, Author: Michael MacDonald, Committer: Jeff Olivier; The sign-off is missing.
Commit sha: 6ab0729, Author: Michael MacDonald, Committer: GitHub; Expected "Michael MacDonald mjmac@google.com", but got "Mohamad Chaarawi mohamad.chaarawi@intel.com".
Commit sha: 264cda4, Author: Michael MacDonald, Committer: GitHub; Expected "Michael MacDonald mjmac@google.com", but got "Kris Jacque kris.jacque@intel.com".
Commit sha: b13e973, Author: Michael MacDonald, Committer: GitHub; Expected "Michael MacDonald mjmac@google.com", but got "Cedric Koch-Hofer cedric.koch-hofer@intel.com".
Commit sha: 654af60, Author: wangdi, Committer: Jeff Olivier; Expected "wangdi di.wang@intel.com", but got "Di Wang di.wang@intel.com".
Commit sha: 613a907, Author: wangdi, Committer: Jeff Olivier; Expected "wangdi di.wang@intel.com", but got "Di Wang di.wang@intel.com".
Commit sha: 2c77ae6, Author: wangdi, Committer: Jeff Olivier; Expected "wangdi di.wang@intel.com", but got "Di Wang di.wang@intel.com".
Commit sha: 18d939f, Author: wangdi, Committer: Jeff Olivier; Expected "wangdi di.wang@intel.com", but got "Di Wang di.wang@intel.com".
Commit sha: 06909a1, Author: wangdi, Committer: Jeff Olivier; Expected "wangdi di.wang@intel.com", but got "Di Wang di.wang@intel.com".
Commit sha: 8db4976, Author: wangdi, Committer: Jeff Olivier; Expected "wangdi di.wang@intel.com", but got "Di Wang di.wang@intel.com".
Commit sha: 22d72fb, Author: wangdi, Committer: Jeff Olivier; Expected "wangdi di.wang@intel.com", but got "Di Wang di.wang@intel.com".