-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: New UI for tagging module #17488
Open
zisoft
wants to merge
21
commits into
darktable-org:master
Choose a base branch
from
zisoft:tag-ui
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+688
−332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the mockup of @Ni-Ti in #15172 I have started to implement a new UI for the tagging module.
For now I have replaced the top treeview for the attached tags with a GTK Flowbox containing the tag labels:
The tag labels only contain the leave of the tags. The full hierarchy can always be shown by hovering:
The toggle switch for displaying the internal darktable tags is removed from the UI and now a module preference:
The styling is completely done in CSS, widget name is
#tag-label
. A tag label can have additional CSS classes based on the type/status of the tag. I have setup a basic CSS styling as follows:Internal darktable tags are dimmed. They cannot be selected. CSS class
darktable
Category tags have italic font. CSS class
category
Tags marked as private get the CSS class
private
(no basic design from me).If multiple images are selected and some tags are attached to only some of these images they get a dashed border. CSS class
some
:This part is fully functional so far and can be tested.
This is still WIP and if this doesn't get completely torn apart in the air I would continue with the dictionary part of the tagging module.
Would like to hear what you think so far.
closes #15172