Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update general.md to include en@truecase. #677

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

RokeJulianLockhart
Copy link
Contributor

@RokeJulianLockhart RokeJulianLockhart commented Sep 1, 2024

Added information about `en@truecase`.
@elstoc
Copy link
Contributor

elstoc commented Sep 1, 2024

Is there a reason this is marked as draft? Do you still have further work to do on it?

@@ -8,7 +8,7 @@ draft: false
Control the overall look and feel of darktable.

interface language
: Set the language of the user interface. The system default is marked with an * (needs a restart)
: Set the language of the user interface. It includes the option to enable sentence case (`en@truecase`) for `en` (currently the `US` variant, and may not apply to subsequent variants). The system default is marked with an * (needs a restart)
Copy link
Contributor

@elstoc elstoc Sep 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably wouldn't bother mentioning "variants" of EN at the moment since there's currently only one. We can update if another is introduced later.

This comment was marked as off-topic.

Copy link
Contributor Author

@RokeJulianLockhart RokeJulianLockhart Sep 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RokeJulianLockhart
Copy link
Contributor Author

#677 (comment)

I predicted that there was a 50% chance you'd say what you did in #677 (comment), so I marked it as a draft. When I've remediated that, I'll mark it ready for review.

@elstoc
Copy link
Contributor

elstoc commented Sep 1, 2024

I predicted that there was a 50% chance you'd say what you did in #677 (comment), so I marked it as a draft.

Ok, no problem. Generally it's best practice to only mark things as draft if you're currently working on them. Sometimes I'll refrain from reviewing things that are still in draft status. I only reviewed this time because I assumed you were finished, despite the status.

@RokeJulianLockhart RokeJulianLockhart marked this pull request as ready for review September 1, 2024 14:37
@elstoc
Copy link
Contributor

elstoc commented Sep 1, 2024

Thanks!

@elstoc elstoc merged commit 20ebf47 into darktable-org:master Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants