Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support augmentation-declared constructors and methods. #3712

Merged
merged 1 commit into from
Mar 11, 2024

Commits on Mar 9, 2024

  1. Support augmentation-declared constructors and methods.

    The gist of this is to not just ask an Element for it's methods and for its
    constructors, but make sure to ask the augmented element, if there is one.
    
    A few fixes are made additionally:
    
    * While working on this, I saw that a crash would mean that the
      AnalysisContextCollectionImpl was never `disposed`. So I tidied that all back
      into PackageBuilder. It can not be the PackageBuilder's caller's
      responsibility to dispose, because that amounts to have a dozen places in
      tests.
    * In the code that gathers inheritance info, we also need to make sure to grab
      an element's augmented declaration, if there is one.
    srawlins committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    7230d62 View commit details
    Browse the repository at this point in the history