Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include extension members on the extended type's page #3863

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Sep 2, 2024

In this feature, we list extension members of an extended type on that extended type's page. The members are listed inline with other instance members and are cross-linked over to the extension's member pages.

  • Introduce availableInstanceMethods as a list combining both instance methods declared in a container, and instance methods declared in an applicable extension. The same for availableInstanceOperators and availableInstanceFields.
  • Introduce some constructors like Field.providedByExtension for members that are provided by an extension.
  • Add lots of documentation clarifying where various members come from.
  • We introduce a new getter on ElementType, nameWithGenericsPlain, which is not HTML-formatted, for use in HTML "title text."

Here are some screenshots:

Screenshot 2024-08-27 at 1 48 06 PM
Screenshot 2024-08-27 at 1 48 21 PM
Screenshot 2024-09-06 at 2 53 11 PM
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins srawlins marked this pull request as draft September 2, 2024 16:03
Fixes dart-lang#2021

In this feature, we list extension members of an extended type on that extended
type's page. The members are listed inline with other instance members and are
cross-linked over to the extension's member pages.

* Introduce `availableInstanceMethods` as a list combining both instance
  methods declared in a container, and instance methods declared in an
  applicable extension. The same for `availableInstanceOperators` and
  `availableInstanceFields`.
* Introduce some constructors like `Field.providedByExtension` for members that
  are provided by an extension.
* Add lots of documentation clarifying _where_ various members come from.
* We introduce a new getter on ElementType, `nameWithGenericsPlain`, which is
  not HTML-formatted, for use in HTML "title text."
@srawlins srawlins marked this pull request as ready for review September 6, 2024 22:57
@srawlins
Copy link
Member Author

srawlins commented Sep 6, 2024

Be excited, @dart-lang/analyzer-team, this is ready for review 😁 😀 😁 😀

@srawlins srawlins merged commit ca98b89 into dart-lang:main Sep 10, 2024
9 checks passed
@srawlins srawlins deleted the include-extension-methods-2 branch September 10, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants