Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search which is not using canonical libraries as enclosing elements #3877

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

srawlins
Copy link
Member

Search is broken at api.dart.dev/dev, e.g. https://api.dart.dev/dev/3.6.0-228.0.dev/dart-collection/Queue-class.html

This fixes that. I move the assertions from the code that reads the index.json file to the code that writes the index.json file. I also use a library member's canonical library as it's enclosing element in the search results.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins
Copy link
Member Author

Ready for review, @dart-lang/analyzer-team

Copy link
Member

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what I'm looking at, but I also don't see anything obviously questionable.

@srawlins
Copy link
Member Author

Nothing obviously questionable is good enough for me :D

@srawlins srawlins merged commit 0a52976 into dart-lang:main Sep 13, 2024
7 checks passed
@srawlins srawlins deleted the fix-search branch September 13, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants