Upgrade analysis SDK + dartdoc (#8014)

dart-lang · Sep 4, 2024 · 2414357 · 2414357
1 parent c7a0f7b
commit 2414357
Show file tree

Hide file tree

Showing 9 changed files with 36 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,9 @@ Important changes to data models, configuration, and migrations between each
 AppEngine version, listed here to ease deployment and troubleshooting.
 
 ## Next Release (replace with git tag when deployed)
+ * Bumped runtimeVersion to `2024.09.04`.
+ * Upgraded stable Dart analysis SDK to `3.5.2`
+ * Upgraded dartdoc to `8.1.0`.
 
 ## `20240829t084400-all`
  * Bumped runtimeVersion to `2024.08.27`.

diff --git a/Dockerfile.worker b/Dockerfile.worker
@@ -23,7 +23,7 @@ RUN mkdir -p /home/worker/config/dart-stable
 RUN mkdir -p /home/worker/config/flutter-stable
 
 # Setup Dart SDK into /home/worker/dart/{stable,preview}/
-RUN XDG_CONFIG_HOME=/home/worker/config/dart-stable tool/setup-dart.sh /home/worker/dart/stable 3.5.1
+RUN XDG_CONFIG_HOME=/home/worker/config/dart-stable tool/setup-dart.sh /home/worker/dart/stable 3.5.2
 
 # Setup Flutter SDK into /home/worker/flutter/{stable,preview}/
 RUN XDG_CONFIG_HOME=/home/worker/config/flutter-stable tool/setup-flutter.sh /home/worker/flutter/stable 3.24.1

diff --git a/app/lib/shared/versions.dart b/app/lib/shared/versions.dart
@@ -24,10 +24,10 @@ final RegExp runtimeVersionPattern = RegExp(r'^\d{4}\.\d{2}\.\d{2}$');
 /// when the version switch happens.
 const _acceptedRuntimeVersions = <String>[
   // The current [runtimeVersion].
-  '2024.08.27',
+  '2024.09.04',
   // Fallback runtime versions.
+  '2024.08.27',
   '2024.08.20',
-  '2024.08.09',
 ];
 
 /// Sets the current runtime versions.
@@ -62,7 +62,7 @@ bool shouldGCVersion(String version) =>
 
 // keep in-sync with SDK version in .mono_repo.yml and Dockerfile
 final String runtimeSdkVersion = '3.5.0';
-final String toolStableDartSdkVersion = '3.5.1';
+final String toolStableDartSdkVersion = '3.5.2';
 final String toolStableFlutterSdkVersion = '3.24.1';
 
 final semanticToolStableDartSdkVersion =
@@ -74,4 +74,4 @@ final semanticToolStableFlutterSdkVersion =
 final String panaVersion = pana.packageVersion;
 
 // keep in-sync with pkg/pub-worker/lib/src/bin/pana_wrapper.dart
-final String dartdocVersion = '8.0.14';
+final String dartdocVersion = '8.1.0';
diff --git a/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/TypeEnum.html b/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/TypeEnum.html
@@ -72,6 +72,14 @@ <h1>
                 <li>TypeEnum</li>
               </ul>
             </dd>
+            <dt>Available extensions</dt>
+            <dd>
+              <ul class="comma-separated clazz-relationships">
+                <li>
+                  <a href="https://api.dart.dev/stable/%%stable-dart-version%%/dart-core/EnumName.html">EnumName</a>
+                </li>
+              </ul>
+            </dd>
           </dl>
         </div>
         <div class="summary offset-anchor" id="values">

diff --git a/app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/TypeEnum.html b/app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/TypeEnum.html
@@ -70,6 +70,14 @@ <h1>
                 <li>TypeEnum</li>
               </ul>
             </dd>
+            <dt>Available extensions</dt>
+            <dd>
+              <ul class="comma-separated clazz-relationships">
+                <li>
+                  <a href="https://api.dart.dev/stable/%%stable-dart-version%%/dart-core/EnumName.html">EnumName</a>
+                </li>
+              </ul>
+            </dd>
           </dl>
         </div>
         <div class="summary offset-anchor" id="values">

diff --git a/app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/TypeEnum.html b/app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/TypeEnum.html
@@ -70,6 +70,14 @@ <h1>
                 <li>TypeEnum</li>
               </ul>
             </dd>
+            <dt>Available extensions</dt>
+            <dd>
+              <ul class="comma-separated clazz-relationships">
+                <li>
+                  <a href="https://api.dart.dev/stable/%%stable-dart-version%%/dart-core/EnumName.html">EnumName</a>
+                </li>
+              </ul>
+            </dd>
           </dl>
         </div>
         <div class="summary offset-anchor" id="values">

diff --git a/pkg/pub_worker/lib/src/bin/pana_wrapper.dart b/pkg/pub_worker/lib/src/bin/pana_wrapper.dart
@@ -34,7 +34,7 @@ const _totalTimeout = Duration(minutes: 50);
 
 /// The dartdoc version to use.
 /// keep in-sync with app/lib/shared/versions.dart
-const _dartdocVersion = '8.0.14';
+const _dartdocVersion = '8.1.0';
 
 /// Program to be used as subprocess for running pana, ensuring that we capture
 /// all the output, and only run analysis in a subprocess that can timeout and

diff --git a/third_party/dartdoc/resources/docs.dart.js.map b/third_party/dartdoc/resources/docs.dart.js.map
diff --git a/third_party/dartdoc/resources/styles.css b/third_party/dartdoc/resources/styles.css
@@ -661,6 +661,7 @@ footer a, footer a:hover {
 }
 
 .markdown.desc {
+  margin-bottom: 1em;
   max-width: 700px;
 }