Skip to content

Commit

Permalink
Enable reporting without the experimental cookie.
Browse files Browse the repository at this point in the history
  • Loading branch information
@isoos
isoos committed Aug 26, 2024
1 parent b412186 commit 76bbc39
Show file tree
Hide file tree
Showing 14 changed files with 26 additions and 13 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ AppEngine version, listed here to ease deployment and troubleshooting.
* Bumped runtimeVersion to `2024.08.23`.
* Upgraded stable Flutter analysis SDK to `3.24.1`.
* Upgraded dartdoc to `8.0.14`.
* Note: the `report` experiment is enabled by default.

## `20240821t093600-all`
* Bumped runtimeVersion to `2024.08.20`.
Expand Down
2 changes: 1 addition & 1 deletion app/lib/frontend/handlers/experimental.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class ExperimentalFlags {
return params;
}

bool get isReportPageEnabled => isEnabled('report');
bool get isReportPageEnabled => true;

bool get isDarkModeEnabled => isEnabled('dark');
bool get isDarkModeDefault => isEnabled('dark-as-default');
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/pkg_changelog_page.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,8 @@ <h3 class="title">More</h3>
</div>
</main>
<footer class="site-footer">
<a class="link" href="https://dart.dev/">Dart language</a>
<a class="link" href="/report?subject=package%3Aoxygen&amp;url=https%3A%2F%2Fpub.dev%2Fpackages%2Foxygen%2Fchangelog">Report package</a>
<a class="link sep" href="https://dart.dev/">Dart language</a>
<a class="link sep" href="/policy">Policy</a>
<a class="link sep" href="https://www.google.com/intl/en/policies/terms/">Terms</a>
<a class="link sep" href="https://developers.google.com/terms/">API Terms</a>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/pkg_install_page.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,8 @@ <h3 class="title">More</h3>
</div>
</main>
<footer class="site-footer">
<a class="link" href="https://dart.dev/">Dart language</a>
<a class="link" href="/report?subject=package%3Aoxygen&amp;url=https%3A%2F%2Fpub.dev%2Fpackages%2Foxygen%2Finstall">Report package</a>
<a class="link sep" href="https://dart.dev/">Dart language</a>
<a class="link sep" href="/policy">Policy</a>
<a class="link sep" href="https://www.google.com/intl/en/policies/terms/">Terms</a>
<a class="link sep" href="https://developers.google.com/terms/">API Terms</a>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/pkg_score_page.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,8 @@ <h3 class="title">More</h3>
</div>
</main>
<footer class="site-footer">
<a class="link" href="https://dart.dev/">Dart language</a>
<a class="link" href="/report?subject=package%3Aoxygen&amp;url=https%3A%2F%2Fpub.dev%2Fpackages%2Foxygen%2Fscore">Report package</a>
<a class="link sep" href="https://dart.dev/">Dart language</a>
<a class="link sep" href="/policy">Policy</a>
<a class="link sep" href="https://www.google.com/intl/en/policies/terms/">Terms</a>
<a class="link sep" href="https://developers.google.com/terms/">API Terms</a>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/pkg_show_page_discontinued.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,8 @@ <h3 class="title">More</h3>
</div>
</main>
<footer class="site-footer">
<a class="link" href="https://dart.dev/">Dart language</a>
<a class="link" href="/report?subject=package%3Apkg&amp;url=https%3A%2F%2Fpub.dev%2Fpackages%2Fpkg">Report package</a>
<a class="link sep" href="https://dart.dev/">Dart language</a>
<a class="link sep" href="/policy">Policy</a>
<a class="link sep" href="https://www.google.com/intl/en/policies/terms/">Terms</a>
<a class="link sep" href="https://developers.google.com/terms/">API Terms</a>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/pkg_show_page_flutter_plugin.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,8 @@ <h3 class="title">More</h3>
</div>
</main>
<footer class="site-footer">
<a class="link" href="https://dart.dev/">Dart language</a>
<a class="link" href="/report?subject=package%3Aflutter_titanium&amp;url=https%3A%2F%2Fpub.dev%2Fpackages%2Fflutter_titanium">Report package</a>
<a class="link sep" href="https://dart.dev/">Dart language</a>
<a class="link sep" href="/policy">Policy</a>
<a class="link sep" href="https://www.google.com/intl/en/policies/terms/">Terms</a>
<a class="link sep" href="https://developers.google.com/terms/">API Terms</a>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/pkg_show_page_publisher.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,8 @@ <h3 class="title">More</h3>
</div>
</main>
<footer class="site-footer">
<a class="link" href="https://dart.dev/">Dart language</a>
<a class="link" href="/report?subject=package%3Aneon&amp;url=https%3A%2F%2Fpub.dev%2Fpackages%2Fneon">Report package</a>
<a class="link sep" href="https://dart.dev/">Dart language</a>
<a class="link sep" href="/policy">Policy</a>
<a class="link sep" href="https://www.google.com/intl/en/policies/terms/">Terms</a>
<a class="link sep" href="https://developers.google.com/terms/">API Terms</a>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/pkg_show_page_retracted.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,8 @@ <h3 class="title">More</h3>
</div>
</main>
<footer class="site-footer">
<a class="link" href="https://dart.dev/">Dart language</a>
<a class="link" href="/report?subject=package-version%3Apkg%2F1.0.0&amp;url=https%3A%2F%2Fpub.dev%2Fpackages%2Fpkg%2Fversions%2F1.0.0">Report package</a>
<a class="link sep" href="https://dart.dev/">Dart language</a>
<a class="link sep" href="/policy">Policy</a>
<a class="link sep" href="https://www.google.com/intl/en/policies/terms/">Terms</a>
<a class="link sep" href="https://developers.google.com/terms/">API Terms</a>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/pkg_show_page_retracted_non_retracted_version.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,8 @@ <h3 class="title">More</h3>
</div>
</main>
<footer class="site-footer">
<a class="link" href="https://dart.dev/">Dart language</a>
<a class="link" href="/report?subject=package%3Apkg&amp;url=https%3A%2F%2Fpub.dev%2Fpackages%2Fpkg">Report package</a>
<a class="link sep" href="https://dart.dev/">Dart language</a>
<a class="link sep" href="/policy">Policy</a>
<a class="link sep" href="https://www.google.com/intl/en/policies/terms/">Terms</a>
<a class="link sep" href="https://developers.google.com/terms/">API Terms</a>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/pkg_versions_page.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,8 @@ <h3 class="title">More</h3>
</div>
</main>
<footer class="site-footer">
<a class="link" href="https://dart.dev/">Dart language</a>
<a class="link" href="/report?subject=package%3Aoxygen&amp;url=https%3A%2F%2Fpub.dev%2Fpackages%2Foxygen%2Fversions">Report package</a>
<a class="link sep" href="https://dart.dev/">Dart language</a>
<a class="link sep" href="/policy">Policy</a>
<a class="link sep" href="https://www.google.com/intl/en/policies/terms/">Terms</a>
<a class="link sep" href="https://developers.google.com/terms/">API Terms</a>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/publisher_activity_log_page.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,8 @@ <h1 class="title">example.com</h1>
</div>
</main>
<footer class="site-footer">
<a class="link" href="https://dart.dev/">Dart language</a>
<a class="link" href="/report?subject=publisher%3Aexample.com&amp;url=https%3A%2F%2Fpub.dev%2Fpublishers%2Fexample.com%2Factivity-log">Report publisher</a>
<a class="link sep" href="https://dart.dev/">Dart language</a>
<a class="link sep" href="/policy">Policy</a>
<a class="link sep" href="https://www.google.com/intl/en/policies/terms/">Terms</a>
<a class="link sep" href="https://developers.google.com/terms/">API Terms</a>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/publisher_admin_page.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,8 @@ <h2>Members</h2>
</div>
</main>
<footer class="site-footer">
<a class="link" href="https://dart.dev/">Dart language</a>
<a class="link" href="/report?subject=publisher%3Aexample.com&amp;url=https%3A%2F%2Fpub.dev%2Fpublishers%2Fexample.com%2Fadmin">Report publisher</a>
<a class="link sep" href="https://dart.dev/">Dart language</a>
<a class="link sep" href="/policy">Policy</a>
<a class="link sep" href="https://www.google.com/intl/en/policies/terms/">Terms</a>
<a class="link sep" href="https://developers.google.com/terms/">API Terms</a>
Expand Down
3 changes: 2 additions & 1 deletion app/test/frontend/golden/publisher_unlisted_packages_page.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,8 @@ <h3 class="packages-title">
</div>
</main>
<footer class="site-footer">
<a class="link" href="https://dart.dev/">Dart language</a>
<a class="link" href="/report?subject=publisher%3Aexample.com&amp;url=https%3A%2F%2Fpub.dev%2Fpublishers%2Fexample.com%2Funlisted-packages">Report publisher</a>
<a class="link sep" href="https://dart.dev/">Dart language</a>
<a class="link sep" href="/policy">Policy</a>
<a class="link sep" href="https://www.google.com/intl/en/policies/terms/">Terms</a>
<a class="link sep" href="https://developers.google.com/terms/">API Terms</a>
Expand Down

0 comments on commit 76bbc39

Please sign in to comment.