Skip to content

Commit

Permalink
Upgrade pana and Dart analysis SDK
Browse files Browse the repository at this point in the history
  • Loading branch information
isoos committed Aug 20, 2024
1 parent 8e43af3 commit 8881e42
Show file tree
Hide file tree
Showing 9 changed files with 35 additions and 10 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ Important changes to data models, configuration, and migrations between each
AppEngine version, listed here to ease deployment and troubleshooting.

## Next Release (replace with git tag when deployed)
* Bumped runtimeVersion to `2024.08.20`.
* Upgraded stable Dart analysis SDK to `3.5.1`
* Upgraded pana to `0.22.11`.

## `20240815t121700-all`
* Bumped runtimeVersion to `2024.08.09`.
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.worker
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ RUN mkdir -p /home/worker/config/dart-stable
RUN mkdir -p /home/worker/config/flutter-stable

# Setup Dart SDK into /home/worker/dart/{stable,preview}/
RUN XDG_CONFIG_HOME=/home/worker/config/dart-stable tool/setup-dart.sh /home/worker/dart/stable 3.5.0
RUN XDG_CONFIG_HOME=/home/worker/config/dart-stable tool/setup-dart.sh /home/worker/dart/stable 3.5.1

# Setup Flutter SDK into /home/worker/flutter/{stable,preview}/
RUN XDG_CONFIG_HOME=/home/worker/config/flutter-stable tool/setup-flutter.sh /home/worker/flutter/stable 3.24.0
Expand Down
6 changes: 3 additions & 3 deletions app/lib/shared/versions.dart
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ final RegExp runtimeVersionPattern = RegExp(r'^\d{4}\.\d{2}\.\d{2}$');
/// when the version switch happens.
const _acceptedRuntimeVersions = <String>[
// The current [runtimeVersion].
'2024.08.09',
'2024.08.20',
// Fallback runtime versions.
'2024.08.09',
'2024.08.08',
'2024.08.05',
];

/// Sets the current runtime versions.
Expand Down Expand Up @@ -62,7 +62,7 @@ bool shouldGCVersion(String version) =>

// keep in-sync with SDK version in .mono_repo.yml and Dockerfile
final String runtimeSdkVersion = '3.5.0';
final String toolStableDartSdkVersion = '3.5.0';
final String toolStableDartSdkVersion = '3.5.1';
final String toolStableFlutterSdkVersion = '3.24.0';

final semanticToolStableDartSdkVersion =
Expand Down
4 changes: 2 additions & 2 deletions app/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -565,10 +565,10 @@ packages:
dependency: "direct main"
description:
name: pana
sha256: f0e7f53b2972ca8d2e00b32a9577a10ef140aafcd1796b087e8de425c51699dd
sha256: cb8b252c59e517ba0573da63e83215dfd3a7cd5a9b7a0549e9b9547ab7d1ce40
url: "https://pub.dev"
source: hosted
version: "0.22.10"
version: "0.22.11"
path:
dependency: "direct main"
description:
Expand Down
2 changes: 1 addition & 1 deletion app/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ dependencies:
watcher: ^1.0.0
yaml: '^3.0.0'
# pana version to be pinned
pana: '0.22.10'
pana: '0.22.11'
# 3rd-party packages with pinned versions
mailer: '6.1.2'
ulid: '2.0.0'
Expand Down
11 changes: 11 additions & 0 deletions app/test/task/testdata/goldens/packages/oxygen/score.html
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,17 @@ <h3>
<li>✓ macOS</li>
<li>✓ Web</li>
</ul>
<h3>
<img class="report-summary-icon" src="/static/hash-%%etag%%/img/report-ok-icon-green.svg"/>
0/0 points: WASM compatibility
</h3>
<p>
Package is compatible with runtime
<code>wasm</code>
. See
<a href="https://dart.dev/web/wasm">https://dart.dev/web/wasm</a>
for details.
</p>
</div>
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,17 @@ <h3>
<li>✓ macOS</li>
<li>✓ Web</li>
</ul>
<h3>
<img class="report-summary-icon" src="/static/hash-%%etag%%/img/report-ok-icon-green.svg"/>
0/0 points: WASM compatibility
</h3>
<p>
Package is compatible with runtime
<code>wasm</code>
. See
<a href="https://dart.dev/web/wasm">https://dart.dev/web/wasm</a>
for details.
</p>
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions pkg/pub_worker/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -479,10 +479,10 @@ packages:
dependency: "direct main"
description:
name: pana
sha256: f0e7f53b2972ca8d2e00b32a9577a10ef140aafcd1796b087e8de425c51699dd
sha256: cb8b252c59e517ba0573da63e83215dfd3a7cd5a9b7a0549e9b9547ab7d1ce40
url: "https://pub.dev"
source: hosted
version: "0.22.10"
version: "0.22.11"
path:
dependency: transitive
description:
Expand Down
2 changes: 1 addition & 1 deletion pkg/pub_worker/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies:
appengine: ^0.13.6
json_annotation: ^4.3.0
jsontool: ^1.1.0
pana: ^0.22.10
pana: ^0.22.11
lints: ^4.0.0 # required for pana
meta: ^1.7.0
api_builder:
Expand Down

0 comments on commit 8881e42

Please sign in to comment.