Implement _flutter.listViews #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flutter engine in native world registers _flutter.listViews extension on the VM. Flutter app registers extensions on the VM as well, and clients such as dart-code that are connected to flutter daemon call those extensions. Flutter daemon calls _flutter.listViews before proceeding to call methods registered by the app. The web engine does not have information about the VM and its isolates so it cannot implement _flutter.listViews method that requires this information. For a short term solution, register _flutter.listViews directly in dwds vm client.
|
/cc @jonahwilliams - FYI |
grouma
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flutter engine in native world registers _flutter.listViews
extension on the VM. Flutter app registers extensions on the
VM as well, and clients such as dart-code that are connected
to flutter daemon call those extensions. Flutter daemon calls
_flutter.listViews before proceeding to call methods registered
by the app.
The web engine does not have information about the VM and its
isolates so it cannot implement _flutter.listViews method that
requires this information.
As a short term solution, register _flutter.listViews directly
in dwds vm client.
Closes: flutter/flutter#81516
Related: #1315