Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume until end of document if there is no newline when removing from #76

Merged
merged 1 commit into from
May 6, 2024
Merged

Consume until end of document if there is no newline when removing from #76

merged 1 commit into from
May 6, 2024

Conversation

jonasfj
Copy link
Member

@jonasfj jonasfj commented May 6, 2024

block map.

Fixes #55.

@jonasfj jonasfj requested a review from sigurdm May 6, 2024 11:58
sigurdm
sigurdm approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried also with lists?

@jonasfj
Copy link
Member Author

jonasfj commented May 6, 2024

Have you tried also with lists?

No, one issue at the time 🙈

I think there is also a possibility of bugs with inline blocks.

@jonasfj jonasfj merged commit d15b44c into dart-lang:main May 6, 2024
18 checks passed
@jonasfj jonasfj deleted the fix-55-reopened branch May 6, 2024 13:05
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request May 6, 2024
@devoncarew
[deps] rev async, bazel_worker, benchmark_harness, boolean_selector, …
1afb12f 
…browser_launcher, cli_util, clock, collection, convert, crypto, csslib, dartdoc, ecosystem, http, webdev, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/0370a67..09cba7f):
  09cba7f  2024-05-03  Devon Carew  blast_repo fixes (dart-lang/async#273)

bazel_worker (https://github.com/dart-lang/bazel_worker/compare/d396d3d..2fb4fbf):
  2fb4fbf  2024-05-03  Devon Carew  blast_repo fixes (dart-lang/bazel_worker#91)
  de7c44b  2024-05-02  dependabot[bot]  Bump actions/checkout from 4.1.2 to 4.1.4 (dart-lang/bazel_worker#89)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/3a6ed5d..accc755):
  accc755  2024-05-03  Devon Carew  blast_repo fixes (dart-lang/benchmark_harness#105)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/b353222..2cbd4a6):
  2cbd4a6  2024-05-03  Devon Carew  blast_repo fixes (dart-lang/boolean_selector#60)

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/e5687b4..0dcf224):
  0dcf224  2024-05-03  Devon Carew  blast_repo fixes (dart-lang/browser_launcher#59)

cli_util (https://github.com/dart-lang/cli_util/compare/5103eca..9fe3eeb):
  9fe3eeb  2024-05-03  Devon Carew  blast_repo fixes (dart-lang/cli_util#103)

clock (https://github.com/dart-lang/clock/compare/c7e3875..80e70ac):
  80e70ac  2024-05-03  Devon Carew  blast_repo fixes (dart-lang/clock#64)

collection (https://github.com/dart-lang/collection/compare/34b7269..4718398):
  4718398  2024-05-03  Devon Carew  blast_repo fixes (dart-lang/collection#340)

convert (https://github.com/dart-lang/convert/compare/5da924b..056626e):
  056626e  2024-05-03  Devon Carew  blast_repo fixes (dart-lang/convert#105)

crypto (https://github.com/dart-lang/crypto/compare/fc5e7c8..3f815ac):
  3f815ac  2024-05-03  Devon Carew  blast_repo fixes (dart-lang/crypto#170)

csslib (https://github.com/dart-lang/csslib/compare/4ab68e4..141dd65):
  141dd65  2024-05-03  Devon Carew  blast_repo fixes (dart-lang/csslib#201)

dartdoc (https://github.com/dart-lang/dartdoc/compare/d16bedc..6e9c1ea):
  6e9c1eae  2024-05-02  Sam Rawlins  Privatize ModelCommentReference.codeRef and .parsed (dart-lang/dartdoc#3764)

ecosystem (https://github.com/dart-lang/ecosystem/compare/74942f6..9ce560b):
  9ce560b  2024-05-03  dependabot[bot]  Bump the dependencies group with 2 updates (dart-lang/ecosystem#262)
  bbb5c08  2024-05-03  Devon Carew  update dependabot config; update related blast tweak (dart-lang/ecosystem#261)
  678fe95  2024-05-02  dependabot[bot]  Bump peter-evans/create-or-update-comment in the dependencies group (dart-lang/ecosystem#259)
  9f6d4a9  2024-05-02  Devon Carew  Update the dependabot config (dart-lang/ecosystem#258)

http (https://github.com/dart-lang/http/compare/ec73b19..dd31e64):
  dd31e64  2024-05-02  Brian Quinlan  Eagerly free resources on `CupertinoClient.close()` (dart-lang/http#1191)

webdev (https://github.com/dart-lang/webdev/compare/b41ac34..c233e45):
  c233e453  2024-05-02  Elliott Brooks  Move DWDS launch event (dart-lang/webdev#2423)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/fe2699d..c4629ad):
  c4629ad  2024-05-06  Jonas Finnemann Jensen  A few more tests to reduce risk of regressions (dart-lang/yaml_edit#77)
  d15b44c  2024-05-06  Jonas Finnemann Jensen  Consume until end of document if there is no newline when removing from (dart-lang/yaml_edit#76)

Change-Id: I04956b5696ec7cfbeabdd4e0889c2e5934a6f48e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365483
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed yaml edit
2 participants
@jonasfj @sigurdm