Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure nested php tags are also removed when sanitising svg #108

Merged

Conversation

gawpertron
Copy link

No description provided.

@darylldoyle
Copy link
Owner

Thanks for this PR @gawpertron and @adam-holdbrook-technologywithin, great catch! Is there any chance you can update it to get the tests working in the lower PHP versions, please?

The issue seems to be that assertStringNotContainsStringIgnoringCase() wasn't introduced until PHPUnit 7.5 and the PHP 5.6 through 7.1 tests are running on PHPUnit 5.7 and 6.5

@gawpertron gawpertron force-pushed the fix/recursive-php-sanitisation branch 2 times, most recently from a6b3933 to f0d3eca Compare August 7, 2024 11:53
@gawpertron gawpertron force-pushed the fix/recursive-php-sanitisation branch from f0d3eca to 09ed507 Compare August 7, 2024 12:18
@darylldoyle darylldoyle merged commit bcd646a into darylldoyle:master Aug 7, 2024
11 checks passed
@darylldoyle
Copy link
Owner

Thank you @gawpertron!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants