Skip to content

Commit

Permalink
Skip test on windows
Browse files Browse the repository at this point in the history
  • Loading branch information
fjetter committed Mar 10, 2023
1 parent 135fd62 commit a1f1f56
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
2 changes: 2 additions & 0 deletions distributed/protocol/tests/test_protocol.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import dask

from distributed.compatibility import WINDOWS
from distributed.protocol import dumps, loads, maybe_compress, msgpack, to_serialize
from distributed.protocol.compression import (
compressions,
Expand Down Expand Up @@ -396,6 +397,7 @@ def _(header, frames):
assert isinstance(o, MyObj)


@pytest.mark.skipif(WINDOWS, reason="On windows this is triggering a stackoverflow")
def test_deeply_nested_structures():
# These kind of deeply nested structures are generated in our profiling code
def gen_deeply_nested(depth):
Expand Down
13 changes: 7 additions & 6 deletions distributed/shuffle/tests/test_shuffle.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ async def clean_scheduler(
assert not extension.heartbeats


@pytest.mark.skipif(
pa is not None,
reason="We don't have a CI job that is installing a very old pyarrow version",
)
# @pytest.mark.skipif(
# pa is not None,
# reason="We don't have a CI job that is installing a very old pyarrow version",
# )
@gen_cluster(client=True)
async def test_minimal_version(c, s, a, b):
df = dask.datasets.timeseries(
Expand All @@ -85,8 +85,9 @@ async def test_minimal_version(c, s, a, b):
dtypes={"x": float, "y": float},
freq="10 s",
)
with pytest.raises(RuntimeError, match="requires pyarrow"):
await c.compute(dd.shuffle.shuffle(df, "x", shuffle="p2p"))
# with pytest.raises(RuntimeError, match="requires pyarrow"):
res = c.persist(dd.shuffle.shuffle(df, "x", shuffle="p2p"))
await c.compute(res)


@gen_cluster(client=True)
Expand Down

0 comments on commit a1f1f56

Please sign in to comment.