Skip to content

Commit

Permalink
Rename methods from camelCase to a more flat snake_case (#36)
Browse files Browse the repository at this point in the history
All methods have been renamed from camelCase to snake_case for consistency.
  • Loading branch information
nfx committed Mar 27, 2024
1 parent fe2c0ae commit a50c376
Show file tree
Hide file tree
Showing 1,068 changed files with 19,494 additions and 14,131 deletions.
2 changes: 1 addition & 1 deletion .codegen/changelog.md.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ Dependency updates:

{{- define "what" -}}
{{if eq .X "method" -}}
`{{.Method.Service.CamelName}}{{.Method.PascalName}}()` function
[`{{.AsFlat.SnakeName}}()`](https://databrickslabs.github.io/databricks-sdk-r/reference/{{.AsFlat.SnakeName}}.html) function
{{- end}}
{{- end -}}
13 changes: 9 additions & 4 deletions .codegen/service.R.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,20 @@ NULL
{{end}}{{if .Pagination}}#'
#' @return `data.frame` with all of the response pages.
{{end}}#'
#' @rdname {{.Service.CamelName}}{{.PascalName}}
#' @rdname {{.AsFlat.SnakeName}}
#' @alias {{.Service.CamelName}}{{.PascalName}}
#' @export
{{- $hasRequiredFields := and .Request (gt (len .Request.RequiredFields) 0) }}
{{.Service.CamelName}}{{.PascalName}} <- function(client{{- if .Request}}{{range .Request.RequiredFields}}, {{.SnakeName}}{{end -}}
{{.AsFlat.SnakeName}} <- function(client{{- if .Request}}{{range .Request.RequiredFields}}, {{.SnakeName}}{{end -}}
{{- range .Request.NonRequiredFields}}, {{.SnakeName}}=NULL{{end}}
{{- end}}) {
{{- template "method-serialize" .}}
{{template "method-call" .}}
}

#' @rdname {{.AsFlat.SnakeName}}
#' @export
{{.Service.CamelName}}{{.PascalName}} <- {{.AsFlat.SnakeName}}
{{end}}
{{- range .Methods}}{{if and .Wait (not .IsCrudRead)}}{{.Comment "#' " 80}}
#' @param client Required. Instance of DatabricksClient()
Expand All @@ -34,10 +39,10 @@ NULL
#'{{range .Request.Fields}}
#' @param {{.SnakeName}} {{if .Required}}Required. {{end}}{{with .Summary}}{{.}}{{else}}This field has no description yet.{{end}}{{end}}
{{end}}#'
#' @rdname {{.Service.CamelName}}{{.PascalName}}AndWait
#' @rdname {{.AsFlat.SnakeName}}_and_wait
#' @export
{{- $hasRequiredFields := and .Request (gt (len .Request.RequiredFields) 0) }}
{{.Service.CamelName}}{{.PascalName}}AndWait <- function(client{{- if .Request}}{{range .Request.RequiredFields}}, {{.SnakeName}}{{end -}}
{{.AsFlat.SnakeName}}_and_wait <- function(client{{- if .Request}}{{range .Request.RequiredFields}}, {{.SnakeName}}{{end -}}
{{- range .Request.NonRequiredFields}}, {{.SnakeName}}=NULL{{end}}
{{- end}}, timeout={{.Wait.Timeout}}, callback=cli_reporter) {
{{- template "method-serialize" .}}
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@ jobs:
r-version: release
use-public-rspm: true

- name: Install dependencies
run: |
Rscript -e "if (!require(devtools)) install.packages('devtools', repos = 'https://cran.rstudio.com')"
Rscript -e "devtools::install_dev_deps('.')"
- uses: r-lib/actions/setup-r-dependencies@v2
with:
extra-packages: devtools
env:
R_COMPILE_AND_INSTALL_PACKAGES: never

- name: Run tests
run: |
Expand Down
Loading

0 comments on commit a50c376

Please sign in to comment.