Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file permission flags in example #355

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

p-j-smith
Copy link
Contributor

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Closes #317

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
Show correct file permissions in 05-writing-scripts example

Thanks @Parcelli for submitting this issue!

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

@p-j-smith p-j-smith requested a review from vhmcck April 11, 2024 09:01
@p-j-smith p-j-smith self-assigned this Apr 11, 2024
Copy link

github-actions bot commented Apr 11, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/shell-genomics/compare/md-outputs..md-outputs-PR-355

The following changes were observed in the rendered markdown documents:

 05-writing-scripts.md | 4 ++--
 md5sum.txt            | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-04-11 09:02:58 +0000

github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
Copy link
Contributor

@vhmcck vhmcck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Paul. It all looks good!
I will unpin this issue and move a new one to our top 3.
Will come with clarity on what needs to be done from issues #316 and #314.

@vhmcck vhmcck merged commit 47a6ca4 into main Apr 17, 2024
3 checks passed
@vhmcck vhmcck deleted the fix/permissions-example branch April 17, 2024 09:02
github-actions bot pushed a commit that referenced this pull request Apr 17, 2024
Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Apr 17, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request May 7, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request May 14, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request May 21, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request May 28, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Jul 2, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit to gwu-libraries/shell-genomics that referenced this pull request Jul 8, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request datacarpentry#355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Jul 9, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit to gwu-libraries/shell-genomics that referenced this pull request Jul 9, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request datacarpentry#355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Jul 16, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit to gwu-libraries/shell-genomics that referenced this pull request Jul 16, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request datacarpentry#355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit to gwu-libraries/shell-genomics that referenced this pull request Jul 23, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request datacarpentry#355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit to gwu-libraries/shell-genomics that referenced this pull request Jul 30, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request datacarpentry#355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Aug 6, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit to gwu-libraries/shell-genomics that referenced this pull request Aug 6, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request datacarpentry#355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Aug 13, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit to gwu-libraries/shell-genomics that referenced this pull request Aug 13, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request datacarpentry#355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit that referenced this pull request Aug 15, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request #355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit to gwu-libraries/shell-genomics that referenced this pull request Aug 20, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request datacarpentry#355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit to gwu-libraries/shell-genomics that referenced this pull request Aug 27, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request datacarpentry#355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit to gwu-libraries/shell-genomics that referenced this pull request Sep 3, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request datacarpentry#355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit to gwu-libraries/shell-genomics that referenced this pull request Sep 10, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request datacarpentry#355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit to gwu-libraries/shell-genomics that referenced this pull request Sep 17, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request datacarpentry#355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
github-actions bot pushed a commit to gwu-libraries/shell-genomics that referenced this pull request Sep 24, 2024
Auto-generated via {sandpaper}
Source  : eaade5b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-17 09:03:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 47a6ca4
Branch  : main
Author  : vhmcck <114887733+vhmcck@users.noreply.github.com>
Time    : 2024-04-17 09:02:26 +0000
Message : Merge pull request datacarpentry#355 from datacarpentry/fix/permissions-example

Fix file permission flags in example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shell-genomics/05-writing-scripts -incorrect output displayed for $ ls -l bad-reads-script.sh
2 participants