Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper context to rethrow in PrivacyAsyncStorage #1018

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Conversation

zner0L
Copy link
Member

@zner0L zner0L commented Jan 18, 2023

In #1014, we found that proper error messages were missing from PrivacyAsyncStorage, which made it harder to debug. I added those now.

@cypress
Copy link

cypress bot commented Jan 18, 2023



Test summary

79 0 7 0


Run details

Project datenanfragen/website
Status Passed
Commit 4e8f4a5
Started Jan 18, 2023 2:29 PM
Ended Jan 18, 2023 2:33 PM
Duration 03:54 💡
OS Linux Debian - 10.9
Browser Electron 91

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

src/Utility/PrivacyAsyncStorage.ts Outdated Show resolved Hide resolved
src/Utility/PrivacyAsyncStorage.ts Outdated Show resolved Hide resolved
In #1014, we found that proper error messages were missing from PrivacyAsyncStorage, which made it harder to debug. I added those now.
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@baltpeter baltpeter merged commit 84efc46 into master Jan 18, 2023
@baltpeter baltpeter deleted the z_1014 branch January 18, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants