Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp32-s3 dont have DAC #161

Closed
Xekz opened this issue Aug 2, 2022 · 6 comments
Closed

esp32-s3 dont have DAC #161

Xekz opened this issue Aug 2, 2022 · 6 comments
Assignees
@davetcc
Labels
enhancement
Milestone
2.3.5

Comments

@Xekz
Copy link

Xekz commented Aug 2, 2022

esp32-s3/IoAbstraction/src/esp32/ESP32AnalogDevice.cpp:11:10: fatal error: driver/dac.h: No such file or directory
@davetcc
Copy link
Owner

davetcc commented Aug 2, 2022

Apologies but we don't support that board at the moment, we support S2 but we have not got an S3 board to test with. We'll schedule the work to support it though.

@davetcc
Copy link
Owner

davetcc commented Aug 2, 2022

Any pointers on a basic dev board would be helpful.

@davetcc
Copy link
Owner

davetcc commented Aug 3, 2022

I’ve ordered an esp32s3 mini as they look interesting. I’m sure like the s2 there will be a lot of incompatibility early on.

@davetcc davetcc self-assigned this Aug 4, 2022
@davetcc davetcc added this to the 2.3.5 milestone Aug 4, 2022
davetcc pushed a commit that referenced this issue Aug 14, 2022
#161 fix for ESP32S3 compilation. Guard DAC code with conditional blo…
abea3b3 
…cks.
@davetcc
Copy link
Owner

davetcc commented Aug 14, 2022

Fix now on master, tested on an unexpected maker tiny S3. IoAbstraction and TaskManager tests all pass.

@davetcc
Copy link
Owner

davetcc commented Aug 14, 2022

Tested right through to menu creation in tcMenu, all working with encoder too.

@davetcc
Copy link
Owner

davetcc commented Aug 15, 2022

Closing as smoke tested on ESP32, ESP32S2 and ESP32S3

@davetcc davetcc closed this as completed Aug 15, 2022
@fa-yoshinobu fa-yoshinobu mentioned this issue Dec 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davetcc davetcc

Labels
enhancement
Projects
None yet
Milestone
2.3.5
Development

No branches or pull requests
2 participants
@davetcc @Xekz