Skip to content

Commit

Permalink
change: deprecate lollipop()
Browse files Browse the repository at this point in the history
  • Loading branch information
davidgohel committed May 4, 2024
1 parent 2739119 commit c854fe1
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 1 deletion.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: flextable
Title: Functions for Tabular Reporting
Version: 0.9.6.011
Version: 0.9.6.012
Authors@R: c(
person("David", "Gohel", , "david.gohel@ardata.fr", role = c("aut", "cre")),
person("ArData", role = "cph"),
Expand Down
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
- The `path` argument now has a signature of `part = c("body", "header",
"footer", "all")`, but because only a single value can be selected, it
will pick `"body"` by default, as before.
- Deprecate `lollipop()` since it produces (ugly) results that can be replaced
by nice results with `gg_chunk()` or `grid_chunk()`.

## Issues

Expand Down
5 changes: 5 additions & 0 deletions R/chunk_images.R
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,10 @@ linerange <- function(value, min = NULL, max = NULL, rangecol = "#CCCCCC",
#' - [compose()] and [as_paragraph()],
#' - [append_chunks()],
#' - [prepend_chunks()].
#'
#' It is now deprecated and will be soon defunct because we
#' think it produces ugly results. Use [gg_chunk()] to
#' replace it.
#' @param value values containing the bar size
#' @param min min bar size. Default min of value
#' @param max max bar size. Default max of value
Expand Down Expand Up @@ -308,6 +312,7 @@ lollipop <- function(value, min = NULL, max = NULL, rangecol = "#CCCCCC",
height = .2, unit = "in", raster_width = 30, positivecol = "#00CC00",
negativecol = "#CC0000", neutralcol = "#CCCCCC", neutralrange = c(0, 0),
rectanglesize = 2) {
.Deprecated(msg = "lollipop function is deprecated as authors don't like the result, please open an issue if you are using it.")
width <- convin(unit = unit, x = width)
height <- convin(unit = unit, x = height)

Expand Down
4 changes: 4 additions & 0 deletions man/lollipop.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c854fe1

Please sign in to comment.