Skip to content

Commit

Permalink
fix: set 'transparent' bg to almost transparent
Browse files Browse the repository at this point in the history
setting '#FFFFFF00' is still possible
  • Loading branch information
davidgohel committed Feb 24, 2024
1 parent 8dcef40 commit 1cbc8eb
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Package: ggiraph
Type: Package
Title: Make 'ggplot2' Graphics Interactive
Description: Create interactive 'ggplot2' graphics using 'htmlwidgets'.
Version: 0.8.9.004
Version: 0.8.9.005
Authors@R: c(
person("David", "Gohel", role = c("aut", "cre"),
email = "david.gohel@ardata.fr"),
Expand Down
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@
- deprecate ggiraph
- A font check is now done with theme settings (only when argument `ggobj` is used)

## Issues

- When `bg` is set to 'transparent', it's been transformed to almost
transparent '#ffffff01'.


# ggiraph 0.8.8

## Issues
Expand Down
2 changes: 1 addition & 1 deletion R/girafe.R
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ girafe <- function(
args$setdims <- FALSE
# we need a surface with pointer events
if (identical(args$bg, "transparent")) {
args$bg <- "#fffffffd"
args$bg <- "#ffffff01"
}

if (!is.null(ggobj)) {
Expand Down

0 comments on commit 1cbc8eb

Please sign in to comment.