fix: fixed size is now defined within style in inches (#291)

davidgohel · May 7, 2024 · 461eaa1 · 461eaa1
1 parent 3374ba0
commit 461eaa1
Show file tree

Hide file tree

Showing 15 changed files with 29 additions and 28 deletions.
diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml
@@ -20,14 +20,14 @@ jobs:
         config:
           - {os: windows-latest, r: 'devel'}
           - {os: windows-latest, r: 'release'}
-          - {os: macOS-latest, r: 'release'}
+          - {os: macos-latest, r: 'release'}
           - {os: ubuntu-latest, r: 'devel'}
           - {os: ubuntu-latest, r: 'release'}
     env:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - uses: r-lib/actions/setup-pandoc@v2
 

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -2,7 +2,7 @@ Package: ggiraph
 Type: Package
 Title: Make 'ggplot2' Graphics Interactive
 Description: Create interactive 'ggplot2' graphics using 'htmlwidgets'.
-Version: 0.8.10.001
+Version: 0.8.10.003
 Authors@R: c(
     person("David", "Gohel", role = c("aut", "cre"),
     email = "david.gohel@ardata.fr"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,8 +1,13 @@
 # ggiraph 0.8.10
 
+## Issues 
+
+- fixed size is now defined within style in inches, the size is now as expected.
+
 ## Feature
 
 - support trailing commas everywhere
+- Update to tinyxml2 10.0.0
 
 # ggiraph 0.8.9
 

diff --git a/R/element_interactive.R b/R/element_interactive.R
@@ -71,7 +71,6 @@ element_interactive <- function(element_func,
 #' @param label The text for the label (scalar character)
 #' @param ... any of the [interactive_parameters].
 #' @return an interactive label object
-#' @inheritParams rlang list2
 #' @export
 #' @examples
 #' library(ggplot2)

diff --git a/inst/htmlwidgets/girafe.yaml b/inst/htmlwidgets/girafe.yaml
@@ -13,11 +13,11 @@ dependencies:
     src: htmlwidgets/lib/save-svg-as-png-1.4.17
     script: save-svg-as-png.min.js
   - name: flatbush
-    version: 4.0.0
-    src: htmlwidgets/lib/flatbush-4.0.0
+    version: 4.4.0
+    src: htmlwidgets/lib/flatbush-4.4.0
     script: flatbush.min.js
   - name: ggiraphjs
-    version: 0.4.6
-    src: htmlwidgets/lib/ggiraphjs-0.4.6
+    version: 0.8.10
+    src: htmlwidgets/lib/ggiraphjs-0.8.10
     script: ggiraphjs.min.js
     stylesheet: ggiraphjs.min.css
diff --git a/inst/htmlwidgets/lib/d3-lasso-0.0.5/d3-lasso.min.js b/inst/htmlwidgets/lib/d3-lasso-0.0.5/d3-lasso.min.js
diff --git a/inst/htmlwidgets/lib/flatbush-4.0.0/flatbush.min.js b/inst/htmlwidgets/lib/flatbush-4.0.0/flatbush.min.js
diff --git a/inst/htmlwidgets/lib/flatbush-4.4.0/flatbush.min.js b/inst/htmlwidgets/lib/flatbush-4.4.0/flatbush.min.js
diff --git a/inst/htmlwidgets/lib/ggiraphjs-0.4.6/ggiraphjs.min.js b/inst/htmlwidgets/lib/ggiraphjs-0.4.6/ggiraphjs.min.js
diff --git a/...ets/lib/ggiraphjs-0.4.6/ggiraphjs.min.css → ...ts/lib/ggiraphjs-0.8.10/ggiraphjs.min.css b/...ets/lib/ggiraphjs-0.4.6/ggiraphjs.min.css → ...ts/lib/ggiraphjs-0.8.10/ggiraphjs.min.css
diff --git a/inst/htmlwidgets/lib/ggiraphjs-0.8.10/ggiraphjs.min.js b/inst/htmlwidgets/lib/ggiraphjs-0.8.10/ggiraphjs.min.js